Closed
Bug 455500
Opened 16 years ago
Closed 16 years ago
Enormous memory usage with fieldset, legend, audio and DOMAttrModified event listener
Categories
(Core :: Audio/Video, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: martijn.martijn, Assigned: cajbir)
Details
(Keywords: testcase)
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
See testcase, when viewing, that testcase, Mozilla quickly takes up more and more memory, and that seems to go on indefinitely. I haven't really gone past the 500MB boundary, because further than that, I could get problems terminating the firefox.exe process, while the process will take more and more memory, basically making my computer unusable for a long time.
So please beware when opening the testcase in current trunk build! Be prepared to quickly close the firefox.exe process.
The iframe content consists of this:
<fieldset><audio>
<script>window.addEventListener('DOMAttrModified', function() {window.frameElement.parentNode.removeChild(window.frameElement);}, true);</script>
<legend></legend>
Reporter | ||
Comment 1•16 years ago
|
||
Hmm, I seem to get this also with other tags in my testing, so I guess this is not isolated to audio tags. Perhaps this is an event handling issue?
Component: Video/Audio → DOM
QA Contact: video.audio → general
Reporter | ||
Updated•16 years ago
|
Summary: Enormous memory usage with fieldset, legend, audio and DOMAtrrModified event listener → Enormous memory usage with fieldset, legend, audio and DOMAttrModified event listener
Reporter | ||
Comment 2•16 years ago
|
||
This testcase shows that the playbackrate attribute seems to get added, which triggers the DOMAttrModified event listener.
Reporter | ||
Updated•16 years ago
|
Component: DOM → Video/Audio
QA Contact: general → video.audio
Comment 3•16 years ago
|
||
Regression range: 2008072903 - 2008073003
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=07%2F29%2F08&enddate=07%2F30%2F08
-->Bug 448445 (_might be_, couldn't find anything else as a reasonable culprit, but then again that's me) ;)
Comment 4•16 years ago
|
||
So there really shouldn't be any DOMAttrModified events here.
Flags: blocking1.9.1?
Assignee | ||
Comment 5•16 years ago
|
||
The issue was caused due to playbackRate and defaultPlaybackRate being erroneously implemented as content element attributes. These were changed during a call to Load at a bad time.
playbackRate and defaultPlaybackRate are not content element attributes according to the spec. I've removed that and re-implemented them as DOM attributes only. The DOM is no longer modified and both test cases work fine.
Assignee: nobody → chris.double
Attachment #340577 -
Flags: superreview?(roc)
Attachment #340577 -
Flags: review?(roc)
Attachment #340577 -
Flags: superreview?(roc)
Attachment #340577 -
Flags: superreview+
Attachment #340577 -
Flags: review?(roc)
Attachment #340577 -
Flags: review+
Assignee | ||
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: blocking1.9.1?
Reporter | ||
Comment 7•16 years ago
|
||
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080930093007 Minefield/3.1b1pre
Reporter | ||
Comment 8•16 years ago
|
||
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081029 Minefield/3.1b2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•