Closed Bug 455540 Opened 16 years ago Closed 16 years ago

[FIX]Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

Like so
(deleted), patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
This way GetNodeInfo would only fail with NS_ERROR_OUT_OF_MEMORY
Actually, I meant that we should stop doing it in the XULPrototypeDocument caller, since we control that.  But looking again, this seems to be the only caller of the qualifiedName version of GetNodeInfo, so we would in fact be able to remove this overload altogether.
That makes sense, I'll submit a patch unless you beat me to it
Attached patch move qualified name stuff into user (obsolete) (deleted) — — Splinter Review 
i hope this is reasonable
Attachment #338903 - Flags: review?(bzbarsky)
forgot the .h change in the above patch, i'll commit that if i get an r+
I was more thinking change the fastload code to store the localName and prefix separately instead of constructing the qualified name on save and having to parse it on restore...
ok, in that case i'll let you take care of it
Attached patch Like so (deleted) — — Splinter Review 

  

  



        Attachment #338903 -
        Attachment is obsolete: true

        Attachment #340586 -
        Flags: superreview?(jst)

        Attachment #340586 -
        Flags: review?(jst)

        Attachment #338903 -
        Flags: review?(bzbarsky)

    
  
Summary: Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo → [FIX]Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo

        Attachment #340586 -
        Flags: superreview?(jst)

        Attachment #340586 -
        Flags: superreview+

        Attachment #340586 -
        Flags: review?(jst)

        Attachment #340586 -
        Flags: review+

    
  
QA Contact: content

    
    

    
  
Pushed changeset 18e5167ac655.

  

  


Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED

    
  
Component: Content → DOM
QA Contact: content → general
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: