Closed
Bug 455611
Opened 16 years ago
Closed 16 years ago
docshell's NavigationUtils.js needs to be tweaked a bit for Fenenc
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: Gavin)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
gBrowser in Fennec is not the same as the gBrowser in Firefox. This function needs to be change a wee bit to get the right content windows from a chrome window. http://mxr.mozilla.org/mozilla-central/source/docshell/test/navigation/NavigationUtils.js#131
Assignee | ||
Comment 1•16 years ago
|
||
Use the docshell tree instead of tabbrowser methods. Tests pass in Firefox.
Assignee: doug.turner → gavin.sharp
Status: NEW → ASSIGNED
Attachment #339097 -
Flags: review?(bzbarsky)
Comment 2•16 years ago
|
||
That's odd.... The tests that use this really do want just the tabs and nothing else. Can we restrict to those in some sane way? (Is this the time when I get to mutter about needing a better tabbrowser API?)
Depends on: 455607
Assignee | ||
Comment 3•16 years ago
|
||
The windows we get from the extra Firefox docshells are chrome windows, so we could easily filter them out, sure. I didn't bother because none of the tests are affected, since they always just look for the window's they've opened.
Comment 4•16 years ago
|
||
I'd really prefer we filter them our if we can (esp. given the name of this method).
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #339097 -
Attachment is obsolete: true
Attachment #339281 -
Flags: review?(bzbarsky)
Attachment #339097 -
Flags: review?(bzbarsky)
Updated•16 years ago
|
Attachment #339281 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•16 years ago
|
Summary: docshell's NavigationUtils.js needs to be tweeked a bit for Fenenc → docshell's NavigationUtils.js needs to be tweaked a bit for Fenenc
You need to log in
before you can comment on or make changes to this bug.
Description
•