Closed
Bug 456099
Opened 16 years ago
Closed 16 years ago
outparamdel nsIPrivateDOMEvent
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #339510 -
Flags: review?(jst)
Updated•16 years ago
|
QA Contact: content
Comment 1•16 years ago
|
||
Comment on attachment 339510 [details] [diff] [review]
outparamdelling
The nsXMLHttpRequest changes here might have bit-rotted due to a bunch of changes going into that code lately, so watch out for that once you go to land this.
r+sr=jst
Attachment #339510 -
Flags: superreview+
Attachment #339510 -
Flags: review?(jst)
Attachment #339510 -
Flags: review+
Assignee | ||
Comment 2•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 3•15 years ago
|
||
Seeing as there hasn't been any discussions about this bug for 5 months and it's not really something that's testable on testsuite or litmus, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
Comment 4•15 years ago
|
||
The "nsSmartCardEvent.cpp" chunk of this bug's patch was a bit silly:
>diff --git a/security/manager/ssl/src/nsSmartCardEvent.cpp b/security/manager/ssl/src/nsSmartCardEvent.cpp
>-NS_IMETHODIMP nsSmartCardEvent::IsDispatchStopped(PRBool *aIsDispatchPrevented)
>+NS_IMETHODIMP_(PRBool ) nsSmartCardEvent::IsDispatchStopped()
> {
>+ PRBool isDispatchPrevented = nsnull;
>+ PRBool * aIsDispatchPrevented = &isDispatchPrevented;
> NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>- return mPrivate->IsDispatchStopped(aIsDispatchPrevented);
>+ return mPrivate->IsDispatchStopped();
> }
>
>-NS_IMETHODIMP nsSmartCardEvent::GetInternalNSEvent(nsEvent** aNSEvent)
>+NS_IMETHODIMP_(nsEvent*) nsSmartCardEvent::GetInternalNSEvent()
> {
>+ nsEvent* nSEvent = nsnull;
>+ nsEvent** aNSEvent = &nSEvent;
> NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>- return mPrivate->GetInternalNSEvent(aNSEvent);
>+ return mPrivate->GetInternalNSEvent();
> }
>
>-NS_IMETHODIMP nsSmartCardEvent::HasOriginalTarget(PRBool *aResult)
>+NS_IMETHODIMP_(PRBool ) nsSmartCardEvent::HasOriginalTarget()
> {
>+ PRBool result = nsnull;
>+ PRBool * aResult = &result;
> NS_ASSERTION(mPrivate, "SmartCardEvent called without Init");
>- return mPrivate->HasOriginalTarget(aResult);
>+ return mPrivate->HasOriginalTarget();
> }
We created two unused variables in three different functions.
The last function (HasOriginalTarget) has since been removed entirely, but the other two still remain and still trigger build warnings for their unused variables.
Attached followup-patch fixes this.
Attachment #423973 -
Flags: review?(tglek)
Comment 5•15 years ago
|
||
Comment on attachment 423973 [details] [diff] [review]
followup: remove unused variables introduced by earlier patch
I'd requested review from Taras, the author of this bug's original patch, but it looks like he's gone for another 2.5 weeks.
So, I'm redirecting review-request on (trivial) followup to jst, the reviewer of this bug's original patch.
Attachment #423973 -
Flags: review?(tglek) → review?(jst)
Updated•15 years ago
|
Attachment #423973 -
Flags: review?(jst) → review+
Comment 6•15 years ago
|
||
Thanks smaug.
Pushed followup: http://hg.mozilla.org/mozilla-central/rev/672467c31030
Updated•13 years ago
|
Assignee: nobody → tglek
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•