Closed Bug 456342 Opened 16 years ago Closed 16 years ago

also restore non-standard input field types (such as type="search")

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1b2

People

(Reporter: zeniko, Assigned: zeniko)

References

(Blocks 1 open bug, )

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch modified XPath query and tests (obsolete) (deleted) — Splinter Review
Every non-recognized input type falls back to type="text", so we now rather exclude the types that we don't want instead of trying to be comprehensive as to what types we want. Per <http://hg.mozilla.org/mozilla-central/annotate/6f18a6d94920/content/html/content/src/nsHTMLInputElement.cpp#l1968>, that's the following types to ignore: BUTTON, HIDDEN, RESET, IMAGE, PASSWORD and SUBMIT.
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #339759 - Flags: review?(dietrich)
Comment on attachment 339759 [details] [diff] [review] modified XPath query and tests r=me, thanks
Attachment #339759 - Flags: review?(dietrich) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b1
backed out TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_456342.js | Didn't save text for ignored field types - Got 3, expected 0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 3.1b1 → ---
Since 1.9.1, XPath considers attributes to be case sensitive, so we have to lower-case them first. My bad for testing this only on 1.9.0.
Attachment #339759 - Attachment is obsolete: true
Keywords: checkin-needed
Target Milestone: --- → Firefox 3.1b2
Simon or Dao, one question beside. In case of type="search" is it a regression by switching from type="timed" or was its content even not saved?
(In reply to comment #6) You're confusing XUL textboxes (for which there's a deprecated type="timed") with HTML input elements (for which type="search" is currently an inofficial, Webkit introduced extension). If this bug is a regression (which it actually is) then from bug 346337 which restricted too much what is considered to be restorable.
Keywords: regression
Alright, thanks for clarification Simon.
Blocks: 346337
No longer depends on: 346337
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite+
To verify, load this bug's URL, enter some text and then duplicate the tab (e.g. through Ctrl+dragging the tab).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: