Closed
Bug 456548
Opened 16 years ago
Closed 16 years ago
IMAP subfolders not initialized beyond one level in GetSubFolders
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
GetSubFolders for IMAP is not recursive, as a result of which subfolders beyond one level aren't initialized in GetSubFolders. This results in a crash while opening a Windows Search/Spotlight result, because nsMessengerBootstrap::OpenMessengerWindowWithUri assumes that the whole folder tree has been initialized by then, when it clearly hasn't for subfolders beyond one level.
It seems like the frontend is currently responsible for initializing an IMAP folder tree, and this assumption isn't really valid when opening a result from the command line.
David, is this correct? Everything seems to work fine, even if disk storage and msfs are deleted. It'd be great if this makes b1.
Attachment #339942 -
Flags: superreview?(bienvenu)
Attachment #339942 -
Flags: review?(bienvenu)
Comment 1•16 years ago
|
||
Comment on attachment 339942 [details] [diff] [review]
patch v1
Did you try making nsImapMailFolder::CreateSubFolders recursive? That seems a bit more natural.
Assignee | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> (From update of attachment 339942 [details] [diff] [review])
> Did you try making nsImapMailFolder::CreateSubFolders recursive? That seems a
> bit more natural.
In fact, I've just replicated what's done in nsLocalMailFolder. Would you rather we called GetSubFolders for each subfolder inside CreateSubFolders?
Updated•16 years ago
|
Attachment #339942 -
Flags: superreview?(bienvenu)
Attachment #339942 -
Flags: superreview+
Attachment #339942 -
Flags: review?(bienvenu)
Attachment #339942 -
Flags: review+
Comment 3•16 years ago
|
||
thx for fixing this; it will help with the kill-rdf stuff as well.
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 4•16 years ago
|
||
Checked in, changeset id: 405:e842bdf573c3
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•