Closed
Bug 456561
Opened 16 years ago
Closed 16 years ago
Remove obsolete reference to <nsWidgetStateManager.js>
Categories
(Core Graveyard :: Embedding: Packaging, defect)
Core Graveyard
Embedding: Packaging
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
This is the last file in /xpfe/global/resources/content/.
|
Assignee | |
Comment 1•16 years ago
|
||
The toolkit file existed in 1.8(.1)
http://mxr.mozilla.org/mozilla1.8/search?string=nsWidgetStateManager%5C.js®exp=on&case=on
but doesn't in 1.9.1 anymore.
I am not 100% sure that this is the correct fix,
but otherwise something else would have to be done for sure...
Assignee: build-config → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #339959 -
Flags: superreview?(benjamin)
Attachment #339959 -
Flags: review?(benjamin)
|
||
Comment 2•16 years ago
|
||
You have seen that bug 427817 removes nsWidgetStateManager.js completely, right?
|
|
Assignee | |
Comment 3•16 years ago
|
||
Thanks for pointing this out to me.
Then, my Av1 patch is the only additional fix needed,
and I'm now sure it's the good one ;-)
Depends on: 427817
Product: SeaMonkey → Core
Summary: Move nsWidgetStateManager.js from m-c/xpfe to c-c/suite → Remove obsolete reference to <nsWidgetStateManager.js>
Target Milestone: seamonkey2.0beta → mozilla1.9.1b1
|
|
||
Comment 4•16 years ago
|
||
We probably should investigate what in embedding/ we still need at all, I suspect that's a file that can be killed as a whole or so.
|
||
Comment 5•16 years ago
|
||
I think we would have known if anyone used embedding/config/xulprefs.mn since it contains references to a few non-existing files...
|
||
Comment 6•16 years ago
|
||
Comment on attachment 339959 [details] [diff] [review]
(Av1) Cleanup <xulprefs.mn>
Please let's just remove that file
Attachment #339959 -
Flags: superreview?(benjamin)
Attachment #339959 -
Flags: review?(benjamin)
Attachment #339959 -
Flags: review-
|
|
Assignee | |
Comment 7•16 years ago
|
||
Attachment #339959 -
Attachment is obsolete: true
Attachment #340388 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #340388 -
Flags: superreview?(benjamin)
|
|
||
Updated•16 years ago
|
Attachment #340388 -
Flags: superreview?(benjamin)
Attachment #340388 -
Flags: superreview+
Attachment #340388 -
Flags: review?(benjamin)
Attachment #340388 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n (when tree reopens): Bv1]
|
|
Assignee | |
Comment 8•16 years ago
|
||
Comment on attachment 340388 [details] [diff] [review]
(Bv1) Remove <xulprefs.mn>
[Checkin: Comment 8]
http://hg.mozilla.org/mozilla-central/rev/de76b64c50e5
Attachment #340388 -
Attachment description: (Bv1) Remove <xulprefs.mn> → (Bv1) Remove <xulprefs.mn>
[Checkin: Comment 8]
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Component: Build Config → Embedding: Packaging
Flags: in-testsuite-
Keywords: checkin-needed
QA Contact: build-config → packaging
Resolution: --- → FIXED
Whiteboard: [c-n (when tree reopens): Bv1]
Target Milestone: mozilla1.9.1b1 → mozilla1.9.1b2
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•