Closed
Bug 457104
Opened 16 years ago
Closed 16 years ago
nsTextServicesDocument::FirstSelectedBlock dead?
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: taras.mozilla, Assigned: fred.jen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Roc or someone else: It seems that a bunch of methods in editor/ are never called. The are the largest out uncalled methods in Moz. I'd like to start with FirstSelectedBlock as it's the biggest, is it ok to remove it?
Peterv is the right person to ask.
Reporter | ||
Updated•16 years ago
|
No longer blocks: static_analyses
Reporter | ||
Comment 2•16 years ago
|
||
Peterv, By a bunch I mean atleast the following: nsTextServicesDocument::FirstSelectedBlock nsTextServicesDocument::GetDOMRangeFor nsTextServicesDocument::InitWithDocument nsTextServicesDocument::LastBlock nsTextServicesDocument::GetDocument nsTextServicesDocument::GetExtent nsTextServicesDocument::CanEdit nsTextServicesDocument::SetDisplayStyle Is there any reason to keep these?
Reporter | ||
Comment 3•16 years ago
|
||
also nsHTMLEditor::GetParentBlockTags is dead to me nsHTMLEditor::GetNextElementByTagName is dead to me nsHTMLEditor::GetFirstCellInRow is dead to me nsHTMLEditor::GetNextCellInRow is dead to me nsHTMLEditor::IsSubordinateBlock is dead to me nsHTMLEditor::GetHighlightColor is dead to me nsHTMLEditor::HasSameBlockNodeParent is dead to me nsHTMLEditor::ResetTextSelectionForRange is dead to me nsHTMLEditor::GetAbsoluteOffsetsForPoints is dead to me nsHTMLEditor::AddCSSStyleSheet is dead to me are high on the dead code size list
Comment 4•16 years ago
|
||
I'm fine with removing these, but I haven't checked personally whether they're still used or not.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → fred.jen
Assignee | ||
Comment 5•16 years ago
|
||
I took a look in mxr, removed everything that is dead for me and it builds and works fine for me.
Attachment #349940 -
Flags: review?(peterv)
Updated•16 years ago
|
Attachment #349940 -
Flags: superreview+
Attachment #349940 -
Flags: review?(peterv)
Attachment #349940 -
Flags: review+
Comment 6•16 years ago
|
||
Comment on attachment 349940 [details] [diff] [review] removed the functions Pleae also remove InitWithDocument from the comment in nsITextServicesDocument.h.
Comment 7•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/bbb30d93a82f
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•