Closed
Bug 457313
Opened 16 years ago
Closed 16 years ago
nuke dead nsGlobalWindow::ConvertCharset
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #340641 -
Flags: review?(bzbarsky)
Updated•16 years ago
|
Attachment #340641 -
Flags: review?(bzbarsky) → review+
Comment 1•16 years ago
|
||
Comment on attachment 340641 [details] [diff] [review]
nuke convertcharset
Nice catch. Can we nuke the nsICharsetConverterManager include as well?
Updated•16 years ago
|
Attachment #340641 -
Flags: superreview+
Assignee | ||
Comment 2•16 years ago
|
||
pushed 41bb2af34a9b
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•16 years ago
|
||
backed out for now
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•16 years ago
|
||
So how come this got backed out?
Assignee | ||
Comment 5•16 years ago
|
||
i took out the include and that broke the build. It'll push it tomorrow.
Assignee | ||
Comment 6•16 years ago
|
||
Fixed patch, ready for checkin
Attachment #340641 -
Attachment is obsolete: true
Assignee | ||
Comment 7•16 years ago
|
||
this is what i meant to upload
Attachment #341499 -
Attachment is obsolete: true
Assignee | ||
Comment 8•16 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•