Test environment: There are INBOX/TEST_FOLDER and Trash folders 5 messages in TEST_FOLDER Imap server is Zimbra with the following capabilities: * CAPABILITY IMAP4rev1 STARTTLS AUTH=PLAIN AUTH=X-ZIMBRA ACL BINARY CATENATE CHILDREN CONDSTORE ENABLE ESEARCH ID IDLE LIST-EXTENDED LITERAL+ LOGIN-REFERRALS MULTIAPPEND NAMESPACE QRESYNC QUOTA RIGHTS=ektx SASL-IR SEARCHRES UIDPLUS UNSELECT WITHIN^M To reproduce: 1) Select all messages in TEST_FOLDER folder 2) Delete them 3) Wait until pseudo-offline op is executed 4) Rebuild index of folder TEST_FOLDER 5) Undo delete Stack dump at http://pastebin.mozilla.org/544706

fwiw, Can reproduce. (not zimbra) Crash ID: bp-d2ab0e4a-958c-11dd-996b-0013211cbf8a Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20081006 Shredder/3.0a3 ID:20081006095651

> Crash ID: bp-d2ab0e4a-958c-11dd-996b-0013211cbf8a > Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20081006 > Shredder/3.0a3 ID:20081006095651 0 thunderbird.exe morkRowObject::SetRow db/mork/src/morkRowObject.cpp:462 1 thunderbird.exe nsMsgDatabase::CopyHdrFromExistingHdr nsMsgDatabase.cpp:3070 2 thunderbird.exe nsImapOfflineTxn::UndoTransaction nsImapUndoTxn.cpp:550 3 thunderbird.exe nsTransactionItem::UndoTransaction editor/txmgr/src/nsTransactionItem.cpp:197 4 thunderbird.exe nsTransactionItem::UndoChildren editor/txmgr/src/nsTransactionItem.cpp:254 5 thunderbird.exe nsTransactionItem::UndoTransaction editor/txmgr/src/nsTransactionItem.cpp:187 6 thunderbird.exe nsTransactionManager::UndoTransaction editor/txmgr/src/nsTransactionManager.cpp:214 7 thunderbird.exe nsMessenger::Undo nsMessenger.cpp:1381 8 xpcom_core.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101 9 thunderbird.exe XPCWrappedNative::CallMethod js/src/xpconnect/src/xpcwrappednative.cpp:2405 10 thunderbird.exe XPC_WN_CallMethod js/src/xpconnect/src/xpcwrappednativejsops.cpp:1477

taking, patch upcoming

In this situation, we close the existing db and create a new one. This gets undo confused since it's still referring to the msg hdrs that were in the old db. This patch makes us stop crashing, though undo will still not work. Rkent will be happy to see us handing a null store :-) This code gets called if we rebuild the index before the offline playback finishes, which I managed to do once.

Comment on attachment 346547 [details] [diff] [review] fix crash So much for "better" faster IMAP :-P

well, it just exposed a code path that we didn't hit before...who among us hasn't done that before? ;-)

pinging for review - it's basically two null checks.

pinging for review

fix checked in.