Closed Bug 458068 Opened 16 years ago Closed 16 years ago

SVG fill="none" is broken - behaves like fill="black"

Categories

(Core :: SVG, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.1b1

People

(Reporter: duncan.loveday, Assigned: longsonr)

References

Details

(Keywords: regression, testcase, verified1.9.1)

Attachments

(3 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081001 Minefield/3.1b1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20081001 Minefield/3.1b1pre

A simple SVG element with fill="none" is being filled with black on the current trunk build. This is the case even if stroke is set to another colour.

Reproducible: Always

Steps to Reproduce:
1. Load the attached
2.
3.
Actual Results:  
The circle and rectangle are both filled with black.

Expected Results:  
The circle and rectangle should not be filled, one is stroked with green and the other blue.
Attached image SVG test case (deleted) —
Keywords: regression, testcase
Regression window: 2008-09-29-02 -- 2008-09-30-02, likely by bug 455984
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Version: unspecified → Trunk
Flags: wanted1.9.1?
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → longsonr
Attachment #341301 - Flags: superreview?(roc)
Attachment #341301 - Flags: review?(roc)
Flags: blocking1.9.1?
Hardware: PC → All
Blocks: 455984
Flags: in-testsuite?
Attached patch reftest (deleted) — Splinter Review
Attachment #341301 - Flags: superreview?(roc)
Attachment #341301 - Flags: superreview+
Attachment #341301 - Flags: review?(roc)
Attachment #341301 - Flags: review+
This needs to go in for b1 -- it breaks google maps.  Testcase: http://tinyurl.com/3n489a
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Whiteboard: check in the patch and the reftest
It looks like a reftest change for bug 455226 snuck into the reftest patch for this bug.
Part of it did but its innocuous. The part to enable that reftest did not sneak in so the reftest isn't run.
(In reply to comment #5)
> This needs to go in for b1 -- it breaks google maps.  Testcase:
> http://tinyurl.com/3n489a

Just FTR, you need to change general.useragent.extra.firefox to be Firefox/3.1b1pre to see this actually happen.
http://hg.mozilla.org/mozilla-central/rev/7a1870bcfef0
http://hg.mozilla.org/mozilla-central/rev/deb6ad2c79b5
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: wanted1.9.1?
Flags: in-testsuite?
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: check in the patch and the reftest
Target Milestone: --- → mozilla1.9.1b1
verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre and Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre. I verified using the testcase in Comment 1.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.1
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: