Closed
Bug 458145
Opened 16 years ago
Closed 16 years ago
Crash [@ nsINode::AppendChildTo] with source, body and link
Categories
(Core :: DOM: HTML Parser, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b1
People
(Reporter: martijn.martijn, Assigned: mrbkap)
References
Details
(4 keywords)
Crash Data
Attachments
(2 files, 1 obsolete file)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
See testcase, which crashes directly or after a few reloads.
http://crash-stats.mozilla.com/report/index/40379c3d-901b-11dd-8b4f-001cc4e2bf68?p=1
0 xul.dll nsINode::AppendChildTo obj-firefox/dist/include/content/nsINode.h:334
1 xul.dll HTMLContentSink::ProcessLINKTag content/html/document/src/nsHTMLContentSink.cpp:2940
2 xul.dll xul.dll@0x30c801
I guess this is a regression from bug 364315.
Assignee | ||
Comment 1•16 years ago
|
||
This is a really bad crash that's a regression from bug 457806. I'm working on a fix; however, given the complexity of the code we're touching, I recommend backing out bug 457806 for beta.
Assignee | ||
Comment 2•16 years ago
|
||
Attachment #341710 -
Flags: superreview?(jst)
Attachment #341710 -
Flags: review?(jst)
Updated•16 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1b1
Comment 3•16 years ago
|
||
Blake and I talked about this and I think our best approach here is to fix this bug with a minimal patch (a subset of Blake's fix in this bug) and do it for beta1. If we don't, we'll need to fix this later in the release that means less testing, or back out the patch that caused this and probably live with the hang in that bug for this whole release. Therefore I think we should take Blake's upcoming patch that is very isolated only to the source element for beta1 and leave things as such for 1.9.1 final.
Assignee | ||
Comment 4•16 years ago
|
||
I included a mochitest too.
Attachment #341710 -
Attachment is obsolete: true
Attachment #341713 -
Flags: superreview?(jst)
Attachment #341713 -
Flags: review?(jst)
Attachment #341710 -
Flags: superreview?(jst)
Attachment #341710 -
Flags: review?(jst)
Updated•16 years ago
|
Attachment #341713 -
Flags: superreview?(jst)
Attachment #341713 -
Flags: superreview+
Attachment #341713 -
Flags: review?(jst)
Attachment #341713 -
Flags: review+
Assignee | ||
Comment 5•16 years ago
|
||
I checked this in on Friday but forgot to note it in the bug: http://hg.mozilla.org/mozilla-central/rev/0c1ec80708a1
Reporter | ||
Comment 6•16 years ago
|
||
Shouldn't this be marked fixed then?
Assignee | ||
Comment 7•16 years ago
|
||
Oops, yeah.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 8•16 years ago
|
||
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre. I verified using the testcase in Comment 0.
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Keywords: fixed1.9.1
Updated•16 years ago
|
Keywords: verified1.9.1
Updated•16 years ago
|
Keywords: fixed1.9.1
Updated•13 years ago
|
Crash Signature: [@ nsINode::AppendChildTo]
You need to log in
before you can comment on or make changes to this bug.
Description
•