Closed
Bug 458864
Opened 16 years ago
Closed 2 years ago
bottom right corner of Aero Glass panel is rectangular
Categories
(Core :: Widget: Win32, defect, P3)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: whimboo, Unassigned, Mentored)
References
()
Details
(Whiteboard: [lang=c++][tpi:+])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
jimm
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20081005 Minefield/3.1b1pre (.NET CLR 3.5.30729) ID:20081005033754
The background of the the bottom-right corner of the Ctrl-Tab panel isn't hidden. So it shines through the border. Do we have forgotten to set the -moz-border-radius? See the attachment for a detailed view.
Updated•16 years ago
|
Component: Theme → Widget: Win32
Product: Firefox → Core
QA Contact: theme → win32
Summary: Background of the bottom-right corner in the Ctrl-Tab panel shines through border → bottom right corner of Aero Glass panel is rectangular
Version: Trunk → 1.9.1 Branch
Comment 1•16 years ago
|
||
I believe this is related to work I'm doing in bug 376408.
Depends on: 376408
Updated•16 years ago
|
Assignee: nobody → jmathies
Comment 2•16 years ago
|
||
I believe the problem here is that this window needs to be something other than a popup class. I tried to address this using window regions in bug 376408, but setting a region blew away the vista glass effect.
Comment 3•16 years ago
|
||
taking some notes here - properies for alt-tab TaskSwitcherOverlayWnd:
ws_overlapped
ws_popup
ws_clipsiblings
ws_ex_topmost
ws_ex_toolwindow
ws_ex_layered
properties for our ctrl-tab window:
ws_overlapped
ws_popup
ws_clipsiblings
ws_clipchildren
ws_thickframe
ws_ex_toolwindow
ws_ex_windowedge
Comment 5•15 years ago
|
||
My patch in bug 506124 still shows this issue. I have a standalone app that has WS_VISIBLE | WS_CLIPCHILDREN | WS_CLIPSIBLINGS and WS_EX_TOPMOST | WS_EX_TOOLWINDOW and doesn't show this issue so I suspect we are doing something wrong.
This issue (and most if not all of the aero glass issues) will not show up in VMWare - they require graphics hardware acceleration.
Status: NEW → ASSIGNED
Comment 6•15 years ago
|
||
This appears to be caused by the CS_DROPSHADOW class style on the window class.
Comment 7•15 years ago
|
||
This patch will create a new native HWND of the same size and parent. It then reparents all the children to the new HWND and stores it back in the nsWindow.
Assignee: jmathies → tellrob
Attachment #390406 -
Flags: superreview?
Attachment #390406 -
Flags: review?(jmathies)
Updated•15 years ago
|
Attachment #390406 -
Flags: superreview? → superreview?(roc)
Comment on attachment 390406 [details] [diff] [review]
v1.0
+namespace {
+static BOOL CALLBACK ReparentWindow(HWND hChild, LPARAM lParam) {
+ HWND parent = (HWND)lParam;
+ ::SetParent(hChild, parent);
+ return TRUE;
+}
+}
The anonymous namespace is superfluous, right?
This otherwise looks good, although it's a super hack. Can you separate out the "recreate window" code into a helper function, though?
Attachment #390406 -
Flags: superreview?(roc) → superreview+
Updated•15 years ago
|
Attachment #390406 -
Flags: review?(jmathies) → review+
Comment 9•14 years ago
|
||
We're no longer using this ctrl+tab panel in Firefox 4. Is this still a useful report?
Reporter | ||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> We're no longer using this ctrl+tab panel in Firefox 4. Is this still a useful
> report?
It isn't a feature which is enabled by default. You will have to enable it with a pref change in about:config. It's still valid.
Rob, what has to be done to get this bug fixed? Doesn't look to be that much, except that the patch could be bitrotted now and that the issue has been fixed on another bug meanwhile?
Updated•13 years ago
|
Comment 13•13 years ago
|
||
Now that tab animations rely on this, it is higher priority.
What still needs to be done to get this fixed?
Updated•13 years ago
|
Assignee: tellrob → nobody
Updated•13 years ago
|
Status: ASSIGNED → NEW
Updated•13 years ago
|
Assignee: nobody → netzen
Updated•13 years ago
|
Severity: minor → normal
Status: NEW → ASSIGNED
Updated•13 years ago
|
Assignee: netzen → nobody
Comment 14•13 years ago
|
||
I haven't started on this yet and I have a couple weeks of silent software update and related work ahead of me so if anyone wants to grab this in the meantime please feel free.
Status: ASSIGNED → NEW
Updated•10 years ago
|
Mentor: jmathies, tabraldes, netzen
Whiteboard: [good first bug][lang=c++]
Comment 16•9 years ago
|
||
Hi, my name is Bahno Mirzad and I am currently studying Open-Source Development at Coventry University. For my first bug, I would like to be assigned to this task.
Thank you.
Comment 17•9 years ago
|
||
NI for comment 16
Flags: needinfo?(tabraldes)
Flags: needinfo?(netzen)
Flags: needinfo?(jmathies)
Comment 18•9 years ago
|
||
(In reply to Bahno Mirzad from comment #16)
> Hi, my name is Bahno Mirzad and I am currently studying Open-Source
> Development at Coventry University. For my first bug, I would like to be
> assigned to this task.
You're welcome to start work on this bug immediately! The bug will be assigned to you once you've written a patch and attached it or it's otherwise clear that progress is being made.
Thanks for wanting to help out!
Flags: needinfo?(tabraldes)
Flags: needinfo?(netzen)
Flags: needinfo?(jmathies)
Updated•9 years ago
|
Mentor: tabraldes
Updated•8 years ago
|
Mentor: netzen
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Whiteboard: [good first bug][lang=c++] → [good first bug][lang=c++][tpi:+]
Comment 19•8 years ago
|
||
Visual appearance of Ctrl+Tab panel is now OK, but I thought that this was bug about "any panel".
Bug 672710 asked specifically for fixing panels, not "Ctrl+Tab panel". I can still reproduce the bug:
1. Open in non-e10s window attachment 356500 [details]
2. Open inspector, remove red background and blue border from <box>
3. Replace "onload" with "onclick" in markup
4. Click on the page to show panel
Either this bug or bug 672710 should be Reopened/Wontfix'd
Flags: needinfo?(jmathies)
Updated•8 years ago
|
Status: RESOLVED → REOPENED
Flags: needinfo?(jmathies)
Priority: -- → P3
Resolution: WORKSFORME → ---
Comment 20•6 years ago
|
||
Hi,
I would like to work on this bug as my first bug. I'm very new to this so might need help with it.
Comment 21•6 years ago
|
||
Can I try this one? I'm also very new to this.
Updated•5 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=c++][tpi:+] → [lang=c++][tpi:+]
Updated•2 years ago
|
Keywords: good-first-bug
Updated•2 years ago
|
Severity: normal → S3
Comment 22•2 years ago
|
||
The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:spohl, could you consider increasing the bug severity?
For more information, please visit auto_nag documentation.
Flags: needinfo?(spohl.mozilla.bugs)
Comment 23•2 years ago
|
||
The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.
Flags: needinfo?(spohl.mozilla.bugs)
Updated•2 years ago
|
Status: REOPENED → RESOLVED
Closed: 8 years ago → 2 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•