Closed Bug 459189 Opened 16 years ago Closed 16 years ago

failed to build firefox on OpenSolaris

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
OpenSolaris
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: eagle.lu, Assigned: eagle.lu)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
(deleted), patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
Attached patch patch (deleted) — — Splinter Review
Trying to build firefox trunk code on OpenSolaris, I got following error "/export/home/brian/moz-ws/community3/builds/build1006/comm-central/mozilla/dom/src/threads/nsDOMWorkerXHRProxy.cpp", line 564: Error: Pointer type needed instead of nsCOMPtr<nsIDOMEventTarget>. "/export/home/brian/moz-ws/community3/builds/build1006/comm-central/mozilla/dom/src/threads/nsDOMWorkerXHRProxy.cpp", line 565: Error: Pointer type needed instead of nsCOMPtr<nsIDOMEventTarget>. "/export/home/brian/moz-ws/community3/builds/build1006/comm-central/mozilla/dom/src/threads/nsDOMWorkerXHRProxy.cpp", line 574: Error: Pointer type needed instead of nsCOMPtr<nsIDOMEventTarget>. 3 Error(s) detected.
Attachment #342394 - Flags: review?(bzbarsky)
Blocks: 449757
Assignee: nobody → brian.lu
Component: General → DOM
Product: Firefox → Core
QA Contact: general → general
I would prefer that whoever reviewed the code you're changing review this...
Attachment #342394 - Flags: review?(bzbarsky) → review?(jst)
Attachment #342394 - Flags: superreview+
Attachment #342394 - Flags: review?(jst)
Attachment #342394 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attached patch patch (obsolete) (deleted) — — Splinter Review
Attachment #345261 - Flags: review?(brendan)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Boying, please file a new bug for new problems -- this bug had a patch landed according to comment 2. Also, I do not see why that cast is needed in attachment 345261 [details] [diff] [review]. GC is already a JSFastNative according to its signature. /be
filed a new bug 462288
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Attachment #345261 - Attachment is obsolete: true
Attachment #345261 - Flags: review?(brendan)
Comment on attachment 345261 [details] [diff] [review] patch In spin-off bug. /be
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: