Closed Bug 459192 Opened 16 years ago Closed 16 years ago

Omnibus ad-blocking bug for October 2008

Categories

(Camino Graveyard :: Annoyance Blocking, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

References

Details

(Keywords: fixed1.8.1.21)

Attachments

(1 file)

Old MacDonald had an ad, e-i-e-i-o…
On technorati, iframe src starting with http://tag.admeld.com/ad/iframe/ (Yeah, we don't block /ad/ in iframe srcs)
So, I found something real puzzling. iframe[src*="/ads/"] blocks ads on arstechnica.com. So far so good. But, when a page on that site is opened in a background tab, or the page is opened from a link in my feed reader (same goes for opening the page from link in email client), the page cannot be scrolled from the keyboard (spacebar, pageUp/Down). adding to ad_blocking.css @-moz-document domain(arstechnica.com) { iframe[class="Banner"] {display:none !important;} } /* this targets the exact same iframes */ then page scrolling from the keyboard works perfectly fine. sample link http://arstechnica.com/news.ars/post/20081031-wifi-thermostat-puts-power-and-cooling-at-your-fingertips.html (this may affect other sites as well, it bites me mostly on Ars)
sfgate.com is showing some Flash and image ads from http://l.yieldmanager.net/apex/mediastore/
The world's worst context sponsored ads show up on imdb pages. They're inside <div id="sponsored_links_afc_div_MIDDLE_CENTER"> and <iframe id="sponsored_links_afc_iframe_MIDDLE_CENTER">
Attached patch Nov08 Omnibus ads (deleted) — Splinter Review
We have enough here and in bug 462776 that I've worked up a patch, which will get us back to being a bit more reactive, especially as we're now working between milestone releases on cvs trunk. This tightens up our *yieldmanager* blocking and blocks everything else here and in bug 462776. I added the iframe rule that philippe provided in the main section of rules; I don't think we should pick on Ars over "Banner", but I think iframe[class="Banner"] (with no *) can be safe enough—if you're sticking content in an iframe with a class of "Banner", it's much more likely to be an ad than if it were <div class="banner"> or something.
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #347236 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 347236 [details] [diff] [review] Nov08 Omnibus ads sr=smorgan; this all looks pretty safe.
Attachment #347236 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Checked in on cvs trunk. Need to nominate for 1.6.6 when I get that flag.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Landed on the MOZILLA_1_8_BRANCH in advance of 1.6.6.
Flags: camino1.6.6+
Keywords: fixed1.8.1.20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: