User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081009 Firefox/2.0.0.11 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081009 Firefox/2.0.0.11 CNN video no longer works with this latest nightly. It worked in yesterday's build. Still broken in the latest hourly build Regression range: Works: http://hg.mozilla.org/mozilla-central/rev/0697b845e1f3 Fails: http://hg.mozilla.org/mozilla-central/rev/e7cad76c3952 Using Flash Player 10 RC Reproducible: Always Steps to Reproduce: 1. Visit the linked URL with the identified builds 2. 3.

The corresponding 20081008 hourly builds are: 1223513265 (Works); 1223515229 (Fails)

Error Console throws out JSON errors. Error: redeclaration of const JSON Source file: http://i.cdn.turner.com/cnn/.element/js/2.0/StorageManager.js Line: 253 Error: redeclaration of const JSON Source file: http://i.cdn.turner.com/cnn/.element/js/2.0/StorageManager.js Line: 253 Error: StorageManager.getInstance is not a function Source file: http://www.cnn.com/ Line: 1011 Error: redeclaration of const JSON Source file: http://i.cdn.turner.com/cnn/.element/js/2.0/StorageManager.js Line: 253

Same here using Vista HP 32bit SP1 and today's nightly: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081009 Minefield/3.1b2pre Firefox/3.0 ID:20081009033154

Adding sites: http://www.huffingtonpost.com/ Error: redeclaration of const JSON Source file: http://www.huffingtonpost.com/assets/js.php?f=flashobjectmin.js-min%2Cjsonmin.js-min%2Ccookiesmin.js-min%2Cv%2Fblogroll.js-min%2Ccommon.js-min%2Clightboxes.js-min%2Cquickview.js-min%2Cshare.js-min%2Cposts.js-min%2Crefresh.js-min%2Cmost_popular.js-min&1223577417 Line: 33 www.netvibes.com Error: redeclaration of const JSON Source file: http://cdn.netvibes.com/js/c/Netvibes.js?v=560 Line: 1 Huffington Post is not loading all the images Netvibes never loads fully. All are kicking similiar JSON errors.

Possibly related to: https://bugzilla.mozilla.org/show_bug.cgi?id=458959 https://bugzilla.mozilla.org/show_bug.cgi?id=459065 I was told on IRC that the JSON was made 'read-only'.. and could be that the sites will have to change. Was indicated on IRC that the dev's will watch and see 'how bad it gets'...

Because this impacts major sites, it should be evaluated by the release team. Also, this bug probably belongs in "Core" and not "Firefox".

jresig thought this was a YUI problem; but we can't really break YUI, can we?

This bug (I think it's this) totally hoses Flickr. We can't ship this.

Is this Windows only? I am not seeing any of these symptoms on OSX using the beta.

Bug 458959 was fixed after branching for Beta 1, so this beta isn't affected.

(In reply to comment #9) > Is this Windows only? I am not seeing any of these symptoms on OSX using the > beta. It also affects Linux see http://reporter.mozilla.org/app/report/?report_id=RMO12235913983142 For the record I'm affected by this on Netvibes too.

Would it be safe to simply not mark this as constant? Sites can redeclare the JSON variable if they wish and sites that want to use the native JSON functionality only need to not define anything else on the JSON variable.

(In reply to comment #13) That's AFAICT what was expected to happen in the first place. There seems however to be a regression of bug 376957 preventing exactly that (see bug 459405).

will add a test, assuming this is the right thing to do

Comment on attachment 343008 [details] [diff] [review] change the prop flags >diff --git a/js/src/json.cpp b/js/src/json.cpp >--- a/js/src/json.cpp >+++ b/js/src/json.cpp >@@ -899,17 +899,16 @@ js_InitJSONClass(JSContext *cx, JSObject > js_InitJSONClass(JSContext *cx, JSObject *obj) > { > JSObject *JSON; > > JSON = JS_NewObject(cx, &js_JSONClass, NULL, obj); > if (!JSON) > return NULL; > if (!JS_DefineProperty(cx, obj, js_JSON_str, OBJECT_TO_JSVAL(JSON), >- JS_PropertyStub, JS_PropertyStub, >- JSPROP_READONLY | JSPROP_PERMANENT)) >+ JS_PropertyStub, JS_PropertyStub, NULL)) s/NULL)/0)/ as noted on IRC -- please get this in, I see dups being filed. Thanks, /be

http://hg.mozilla.org/mozilla-central/rev/5a5fa534d63e testcase: var JSON = "foo";

Marking Verified - CNN, Netvibes and HuffingtonPost all load normally again. Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081016 Minefield/3.1b2pre Firefox/3.0 ID:20081016033525

/cvsroot/mozilla/js/tests/js1_8_1/JSON/regress-459293.js,v <-- regress-459293.js initial revision: 1.1 http://hg.mozilla.org/mozilla-central/rev/6e5c848a2183