Closed
Bug 459615
Opened 16 years ago
Closed 16 years ago
Remove the needElevation param from WinLaunchChild
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
This is now only used by PostUpdate in nsAppRunner.cpp which will be going away as soon as SeaMonkey's post update process has been updated and should be removed.
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #344948 -
Attachment is obsolete: true
Attachment #344950 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #344950 -
Flags: review?(jmathies)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 344950 [details] [diff] [review]
patch
--- a/toolkit/mozapps/update/src/updater/updater.cpp
+ WCHAR *cmdline = (WCHAR *) malloc((len + 1) * sizeof(WCHAR));
You should probably free this pointer later just for cleanliness.
--- a/toolkit/xre/nsAppRunner.cpp
+ wcscat(cmdLine, secondArg);
+ wcscat(cmdLine, logFilePath.get());
Do we need to worry about quoting on logFilePath here?
Attachment #344950 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Thanks Ted. The path doesn't need to be quoted due to the way the helper.exe parses the args.
Attachment #344950 -
Attachment is obsolete: true
Attachment #346690 -
Flags: review+
Attachment #344950 -
Flags: review?(jmathies)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #346690 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 346690 [details] [diff] [review]
patch rev2
bogus patch
|
|
Assignee | |
Comment 6•16 years ago
|
||
Attachment #346692 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #346692 -
Flags: review?(jmathies)
|
|
||
Updated•16 years ago
|
Attachment #346692 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 7•16 years ago
|
||
Attachment #346692 -
Attachment is obsolete: true
Attachment #355061 -
Flags: review+
|
|
Assignee | |
Comment 8•16 years ago
|
||
Pushed to mozilla-central
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
|
|
Assignee | |
Comment 9•16 years ago
|
||
|
|
Assignee | |
Comment 10•16 years ago
|
||
Brad, after this was checked in the Windows Mobile builds broke with the following in the logs
Errors during apply, please fix and refresh bug_465874_env_vars
fatal error: The following error trigger was found: Errors during apply, please fix and refresh
It isn't clear to me why this would break Mobile or how to fix this based on the error so I am cc'ing you to the bug that appears to have caused it
You need to log in
before you can comment on or make changes to this bug.
Description
•