Closed
Bug 459619
Opened 16 years ago
Closed 16 years ago
Add zoom support to reftest harness
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
My patch supports a reftest-zoom attribute on the root element.
Attachment #342829 -
Flags: superreview?(dbaron)
Attachment #342829 -
Flags: review?(dbaron)
Comment 1•16 years ago
|
||
Shouldn't SetupZoom set fullZoom to 1.0 when there's no reftest-zoom attribute? If not, why not?
Maybe your reftest-sanity test should also compare a div with:
width: auto; margin: 10px; height: 10px;
to a div with:
width: auto; margin: 15px; height: 15px;
?
Assignee | ||
Comment 2•16 years ago
|
||
The default is 1.0. We reset the zoom to 1.0 after taking the snapshot, so there shouldn't be any need to set it to 1.0 again for the next test.
Yes, adding that to the reftest-sanity test makes sense.
Comment 3•16 years ago
|
||
Ah... maybe put that assignment to 1.0 in a function called resetZoom() or unsetZoom() just so the symmetry is clear?
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #342829 -
Attachment is obsolete: true
Attachment #343129 -
Flags: superreview?(dbaron)
Attachment #343129 -
Flags: review?(dbaron)
Attachment #342829 -
Flags: superreview?(dbaron)
Attachment #342829 -
Flags: review?(dbaron)
Updated•16 years ago
|
Attachment #343129 -
Flags: superreview?(dbaron)
Attachment #343129 -
Flags: superreview+
Attachment #343129 -
Flags: review?(dbaron)
Attachment #343129 -
Flags: review+
Comment 5•16 years ago
|
||
Comment on attachment 343129 [details] [diff] [review]
fix v2
r+sr=dbaron
Assignee | ||
Comment 6•16 years ago
|
||
Pushed 014c18c2bc29
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 7•16 years ago
|
||
Comment on attachment 343129 [details] [diff] [review]
fix v2
http://hg.mozilla.org/mozilla-central/rev/d153c367c5b5
Was the <nsprpub/configure> change actually wanted ??
Assignee | ||
Comment 8•16 years ago
|
||
No, I backed it out. I wonder why that file is even in the tree at all...
Updated•16 years ago
|
Component: Layout → Reftest
Flags: in-testsuite+
Product: Core → Testing
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•