Closed
Bug 459649
Opened 16 years ago
Closed 16 years ago
URL bar doesn't repaint correctly for the first use of different states
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: mossop, Assigned: dbaron)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The URL bar is no longer updating correctly the first time you focus it or switch to an SSL site. A bisect points at the checkins for bug 322475 as having caused it. I believe that there is some fault with the load of the new background images for each case not completing and displaying.
STR:
1. Open Firefox.
2. Click in the URL bar.
Flags: blocking1.9.1?
Reporter | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
Oops -- it looks like a bunch of DidSetStyleContext implementations don't call their base class DidSetStyleContext method.
Assignee | ||
Comment 3•16 years ago
|
||
(And while we're here we should probably make DidSetStyleContext return void.)
Assignee | ||
Comment 4•16 years ago
|
||
My guess is that this will fix it; I'll try to figure out how to reproduce and verify that it fixes it tomorrow (I'm guessing from the screenshot that I might need to do a Mac build), when I'm not on vacation.
But either way, I'm pretty sure we want this patch.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #342875 -
Flags: superreview?(bzbarsky)
Attachment #342875 -
Flags: review?(bzbarsky)
Comment 5•16 years ago
|
||
Comment on attachment 342875 [details] [diff] [review]
possible patch
r+sr=bzbarsky
Attachment #342875 -
Flags: superreview?(bzbarsky)
Attachment #342875 -
Flags: superreview+
Attachment #342875 -
Flags: review?(bzbarsky)
Attachment #342875 -
Flags: review+
Comment 6•16 years ago
|
||
For what it's worth, I tested the patch (on Mac), and it does fix the problem.
Updated•16 years ago
|
Hardware: PC → All
Assignee | ||
Comment 8•16 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/1ee3957c6617
It's probably worth adding a test for this once we have a framework for testing invalidation bugs (and it might also require a framework for delayed loads in the mochitest HTTP server).
Then again, only the latter would be required for a test with border-image.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Updated•16 years ago
|
Flags: blocking1.9.1?
You need to log in
before you can comment on or make changes to this bug.
Description
•