Closed
Bug 459783
Opened 16 years ago
Closed 15 years ago
TM: We don't trace RegExp() constructor.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 487134
People
(Reporter: gal, Assigned: gal)
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
brendan or mrbkap, could you pick this one up? Its a bit out of my league.
|
Assignee | |
Comment 1•16 years ago
|
||
Blocking speeding up strings-unpack-code.
|
|
Assignee | |
Comment 2•16 years ago
|
||
|
|
Assignee | |
Comment 3•16 years ago
|
||
Assignee: general → gal
Attachment #343471 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Attachment #343483 -
Flags: review?(mrbkap)
|
||
Updated•16 years ago
|
Attachment #343483 -
Flags: review?(mrbkap) → review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 343483 [details] [diff] [review]
new patch, rebased to tip
>diff --git a/js/src/jsregexp.cpp b/js/src/jsregexp.cpp
>+ JS_ReportErrorFlagsAndNumber(cx, JSREPORT_ERROR,
>+ js_GetErrorMessage, NULL,
>+ JSMSG_BAD_FLAG, charBuf);
Nit: align overflow lines with the other parameters, so:
JS_ReportErrorFlagsAndNumber(cx, JSREPORT_ERROR,
js_GetErrorMessage, NULL,
JSMSG_BAD_FLAG, charBuf);
|
|
Assignee | |
Comment 5•16 years ago
|
||
Attachment #344017 -
Flags: review?
|
|
Assignee | |
Comment 6•16 years ago
|
||
Missed the nit and I co-mingled the two patches. Meh.
|
||
Updated•16 years ago
|
Attachment #344017 -
Flags: review? → review?(mrbkap)
|
|
||
Comment 7•16 years ago
|
||
Comment on attachment 344017 [details] [diff] [review]
added testcase and a missing string.replace() case
>diff --git a/js/src/jsbuiltins.h b/js/src/jsbuiltins.h
>+ switch (s[i]) {
>+ case 'g':
>+ *flags |= JSREG_GLOB;
>+ break;
Nit: Please follow the crazy SpiderMonkey switch indentation rules! r=mrbkap with that picked (and brendan's other nit!).
Attachment #344017 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•