Hi, nsRefPtrHashtable.h belongs in sdk/include it includes nsAutoPtr.h which does not belong in sdk/include. Therefore, you cannot use nsRefPtrHashtable.h if you only want to use sdk. Here is part of error I get when compiling: In file included from abbrbkMgr.h:9, from abbrbkMgr.cpp:1: /home/arno//work/xulrunner-sdk/sdk//include/nsRefPtrHashtable.h:44:23: error: nsAutoPtr.h: Aucun fichier ou répertoire de ce type In file included from abbrbkMgr.h:9, from abbrbkMgr.cpp:1: /home/arno//work/xulrunner-sdk/sdk//include/nsRefPtrHashtable.h:56: error: ‘nsRefPtr’ was not declared in this scope /home/arno//work/xulrunner-sdk/sdk//include/nsRefPtrHashtable.h:56: error: wrong number of template arguments (2, should be 3) /home/arno//work/xulrunner-sdk/sdk//include/nsBaseHashtable.h:46: error: provided for ‘template<class KeyClass, class DataType, class UserDataType> class nsBaseHashtable’

modify xpcom/base/Makefile.in to add nsAutoPtr.h to sdk headers

Comment on attachment 343416 [details] [diff] [review] patch v1 If you're going to add it to SDK_HEADERS, you need to remove it from EXPORTS at the same time.

does the patch need super review, or is it ready for checkin ?

Comment on attachment 343958 [details] [diff] [review] patch v2 (removes nsAutoPtr.h from EXPORTS) sr=dveditz benjamin's review was enough for this simple patch.

Comment on attachment 343958 [details] [diff] [review] patch v2 (removes nsAutoPtr.h from EXPORTS) Sorry: { patching file xpcom/base/Makefile.in Hunk #1 FAILED at 75 1 out of 2 hunks FAILED }

oh, xpcom/base/Makefile.in has changed since review. Here is the same patch updated to build with current trunk

Comment on attachment 351720 [details] [diff] [review] patch updated to build with new trunk [Checkin: Comment 8] http://hg.mozilla.org/mozilla-central/rev/865af0f2587a