Closed
Bug 460327
Opened 16 years ago
Closed 16 years ago
remove opportunistic caching
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
()
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
(deleted),
patch
|
mayhemer
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The offline spec recently changed to remove the opportunistic caching feature. Fallback still happens, but a successful load doesn't result in opportunistic caching. This should be pretty easy to take out.
Assignee | ||
Updated•16 years ago
|
Flags: blocking1.9.1?
Assignee | ||
Updated•16 years ago
|
Comment 1•16 years ago
|
||
It really sounds to me like this spec is too unstable to be implementing.... is it too late to just back out on shipping it? :(
Comment 2•16 years ago
|
||
I would just #if 0 or #if OPPORTUNISTIC_CACHING_ENABLED'ed the code. It is not that big part to comment out this way or just remove usage (set) of the flag type NAMESPACE_OPPORTUNISTIC. This will disable the feature w/o huge changes to the code.
Comment 3•16 years ago
|
||
Need to block on resolution of this one way or the other.
Assignee: nobody → dcamp
Flags: blocking1.9.1? → blocking1.9.1+
Assignee | ||
Comment 4•16 years ago
|
||
This is the smallest possible patch to remove this functionality; It leaves support for opportunistic caching in the codebase, but won't actually use it for anything.
We could also do a complete opportunistic-ectomy, either here or in a followup.
Attachment #345379 -
Flags: review?(bzbarsky)
Updated•16 years ago
|
Attachment #345379 -
Flags: superreview+
Attachment #345379 -
Flags: review?(honzab)
Attachment #345379 -
Flags: review?(bzbarsky)
Comment 5•16 years ago
|
||
Comment on attachment 345379 [details] [diff] [review]
quick-n-easy version
Honza should look this over too...
And yeah, followup bug for ripping stuff out (maybe post-1.9.1 if needed) is ok.
Updated•16 years ago
|
Attachment #345379 -
Flags: review?(honzab) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•