Closed
Bug 460333
Opened 16 years ago
Closed 16 years ago
Implement toJSON for primitive wrapper classes
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: sayrer, Assigned: sayrer)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
crowderbt
:
review+
|
Details | Diff | Splinter Review |
Pretty straightforward, also requires Date.toISOString() from ES3.1
|
Assignee | |
Updated•16 years ago
|
Assignee: general → sayrer
|
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #343446 -
Flags: review?(brendan)
|
|
Assignee | |
Updated•16 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1b2
|
|
Assignee | |
Updated•16 years ago
|
Attachment #343445 -
Attachment is obsolete: true
|
||
Comment 3•16 years ago
|
||
Comment on attachment 343446 [details] [diff] [review]
toJSON + toISOString + tests
Brian, can you field this one? I've got an overflowing queue of stuff to do. Thanks.
>+ return date_utc_format(cx, vp, &print_gmt_string);
...
>+ return date_utc_format(cx, vp, &print_iso_string);
Nit: no unary-& needed in C/C++, or used according to house style, for function pointers.
/be
Attachment #343446 -
Flags: review?(brendan) → review?(crowder)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 343446 [details] [diff] [review]
toJSON + toISOString + tests
Is there opposition to growing the PRMJTime year member? Otherwise, and other than Brendan's nit, this looks good to me.
|
|
||
Updated•16 years ago
|
Attachment #343446 -
Flags: review?(crowder) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
In a beta cycle, PRMJTime seems like a pretty high risk place to touch for little benefit.
http://hg.mozilla.org/mozilla-central/rev/8000213aaa7f
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 6•16 years ago
|
||
covered under unittests:
dom/src/json/test/json2.js, dom/src/json/test/unit/test_encode.js
Flags: in-testsuite+
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•