Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1 This only happens in Mac OS X because it's the only one with special styling for window focus, I think. Also, this works just fine in 3.0. Steps to reproduce: 1) Customize your Firefox toolbar, adding a new toolbar with at least a button. Or install an extension that adds a toolbar (it happened to me with Fire.fm). 2) Open a second window, say the Preferences window. Make sure this window is focused and you can see the browser window in the background. Expected result: The Firefox window completely "fades" so that it looks lighted and it's evident that it's out of focus. Obtained result: Everything fades except the new toolbar(s). They look exactly the same as if the window was focused (darker).

I can reproduce this in today's Minefield nightly, but not in Firefox 3.0.3. I tested on OS X 10.4.11. I chose View : Toolbars : Customize, then clicked on the Add New Toolbar button. I named the new toolbar "Test", and dragged the "Copy" button to it.

I hesitate to move this into Firefox::Theme, as I don't think they've done anything that would change this, but I'll cc Kevin just the same :)

I thought about making -moz-appearance: toolbar; meaningful on the Mac. That would fix it.

I caused this regression in bug 439354 (attachment 332240 [details] [diff] [review]).

-moz-appearance: toolbar is currently completely unused in the Mac theme. With this patch it draws dark chrome toolbars.

I also tweaked the border colors of the bookmarks bar to match the native colors.

Comment on attachment 352159 [details] [diff] [review] CSS part, v1: use -moz-appearance: toolbar for toolbars >--- a/toolkit/themes/pinstripe/global/toolbar.css >+++ b/toolkit/themes/pinstripe/global/toolbar.css >@@ -50,19 +50,17 @@ toolbox { > > /* ::::: toolbar & menubar ::::: */ > > toolbar, > toolbarpalette { > min-width: 1px; > min-height: 20px !important; > color: #000000; >- border-top: 1px solid rgba(255,255,255,0.45); >- border-bottom: 1px solid rgba(0,0,0,0.35); >- background-color: #9E9E9E; >+ -moz-appearance: toolbar; > } I don't see why toolbarpalette is styled -- it's never actually visible, right? It's display:none per xul.css and toolbar.xml removes it from the document.

Also when bug 404229 is fixed, the |toolbarpalette| selector won't apply even if the element is in the document.

Comment on attachment 352312 [details] [diff] [review] v2 I missed that in the first pass, but at this point we should also stop hardcoding the text color. (I.e. just remove it, I think.)

I'v just found two more toolbars that need -moz-appearance: none.

Comment on attachment 352321 [details] [diff] [review] v3 > #organizerScopeBar { >+ -moz-appearance: none; > background: url("chrome://global/skin/icons/find-bar-background.png") repeat-x top center #D0D0D0; wtf... global/skin/icons/find-bar-background.png? Anyway.

pushed: http://hg.mozilla.org/mozilla-central/rev/f02f7315ca88 http://hg.mozilla.org/mozilla-central/rev/2963a0f2c388

Comment on attachment 352321 [details] [diff] [review] v3 (In reply to comment #5) > -moz-appearance: toolbar is currently completely unused in the Mac theme. With > this patch it draws dark chrome toolbars. Not true, "menubar" uses it (for embedded xul in for example a xhtml file): -toolbar, -toolbarpalette { +toolbar { min-width: 1px; min-height: 20px !important; - color: #000000; - border-top: 1px solid rgba(255,255,255,0.45); - border-bottom: 1px solid rgba(0,0,0,0.35); - background-color: #9E9E9E; + -moz-appearance: toolbar; } menubar { -moz-appearance: toolbar; min-width: 1px; } .toolbar-holder {

Oh. I wondered what effect that menubar rule had, but now it makes sense.

I've filed bug 469134 about it.

pushed to mozilla-1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8ab138969460 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5df2ac37fdf8

verified FIXED on Shiretoko: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3 ID:20090305133223 and on trunk build: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090331 Minefield/3.6a1pre ID:20090331030637