Closed
Bug 460932
Opened 16 years ago
Closed 16 years ago
text-indent and text-align should really be object attributes
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: surkov)
References
(Blocks 2 open bugs)
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
aaronlev
:
review+
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
It was a mistake to implement these 2 as text attributes. They should be object attributes:
See http://www.linuxfoundation.org/en/Accessibility/IAccessible2/ObjectAttributes
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #344597 -
Flags: review?(aaronleventhal)
Assignee | ||
Updated•16 years ago
|
Attachment #344597 -
Flags: review?(marco.zehe)
Reporter | ||
Comment 2•16 years ago
|
||
Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be asking the frame for info? We do have some major perf issues recently filed about text attributes, which used getComputedStyle.
Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Roc mentioned that getComputedStyle can cause perf issues. Shouldn't we be
> asking the frame for info? We do have some major perf issues recently filed
> about text attributes, which used getComputedStyle.
Yes but Roc said we shouldn't care until we get info it's really perf issue. These text attributes were calculated by getComputedStyle, so I don't change anything when I start to expose them as object attributes. Also I think real perf issue of text attributes is we navigate DOM tree every time for every text attribute.
Updated•16 years ago
|
Attachment #344597 -
Flags: review?(marco.zehe) → review+
Comment 4•16 years ago
|
||
Comment on attachment 344597 [details] [diff] [review]
patch
r=me for the test part.
Reporter | ||
Updated•16 years ago
|
Attachment #344597 -
Flags: review?(aaronleventhal) → review+
Assignee | ||
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•