Bug 420506 has a huge pile of work killing RDF in Thunderbird, we should ensure it doesn't break SeaMonkey *before* this lands.

The first problem is the build breaking in mailnews/base/search/src/nsMsgFilterDataSource.cpp, with the build process not being able to read nsIRDFDataSource.h

This removes the unused nsMsgFilterDataSource and nsMsgFilterDelegateFactory classes. Fixes the build, but MailNews is still broken because (according to Neil) we still use RDF for folder lookups.

Comment on attachment 344110 [details] [diff] [review] Remove unused files [Checkin: Comment 11] Code removal.

Would be nice if you could get patches for whatever we need, and get some kind of reviews to land that stuff on the kill-rdf repo so those land together with merging that back (or in what way ever the landing is planned).

This patch should land on the trunk, actually, if it can. That will make our lives easier. We'll bring it into the kill-rdf repo the next time we merge with the trunk.

What can land on trunk is surely better off there, yes. I just think there will be a few things to patch that depend on things from the kill-rdf repo.

Yes, agreed - I just pointed it out because I think Frank is building against the kill-rdf repo and there will be an extra step involved getting it into the trunk. I'm trying to keep the kill-rdf patch as small as possible to speed up the review, when it comes to time to do reviews.

Comment on attachment 344110 [details] [diff] [review] Remove unused files [Checkin: Comment 11] Yeah, these files weren't used even before we switched to Mercurial. Don't ask me why Thunderbird had to go and #ifdef everything...

(In reply to comment #8) > (From update of attachment 344110 [details] [diff] [review]) > Yeah, these files weren't used even before we switched to Mercurial. Don't ask > me why Thunderbird had to go and #ifdef everything... Just to be clear, these files were ifdef'd because at the time, SeaMonkey still used them. The ifdefs were added on 2008-05-26 (bug 422474) when TB stopped using the files, and SeaMonkey didn't stop using these files until 2008-06-11 (bug 436357).

That's no excuse.

Comment on attachment 344110 [details] [diff] [review] Remove unused files [Checkin: Comment 11] Checked in, changeset 7f037ea11ef6

Looks like the bugs this depends on have landed and we are not broken yet, so mark this fixed with the one patch that is attached here. Let's track further work on porting stuff from jminta's work in bug 460953.