Closed Bug 461327 Opened 16 years ago Closed 16 years ago

White list entries fix

Categories

(Core :: Networking: Cache, defect)

Product:
Core
Component:
Networking: Cache
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

(Keywords: regression)

Attachments

(1 file)

fix 1 [Checkin: Comment 3]
(deleted), patch
dcamp
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review
Attached patch fix 1 [Checkin: Comment 3] (deleted) — — Splinter Review
There are some important nits needed to fix, best before b2: 1. white list entries are always categorized as fallback/opportunistic 2. white list entries are not detected correctly because of wrong select statement
Flags: blocking1.9.1?
Attachment #344462 - Flags: superreview?(bzbarsky)
Attachment #344462 - Flags: review?(dcamp)
Attachment #344462 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 344462 [details] [diff] [review] fix 1 [Checkin: Comment 3] Please add tests that would catch these issues.
(In reply to comment #1) > Please add tests that would catch these issues. There are tests at bug 443017 for a very long but because written in XP-style sooner then all features has been implemented/reviewed/landed it never got checked-in. Now there is a test bunch dependent just on two priority bugs (this one and bug 443023).
Attachment #344462 - Flags: review?(dcamp) → review+
Keywords: checkin-needed
Comment on attachment 344462 [details] [diff] [review] fix 1 [Checkin: Comment 3] http://hg.mozilla.org/mozilla-central/rev/be5c0427be03
Attachment #344462 - Attachment description: fix 1 → fix 1 [Checkin: Comment 3]
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Flags: blocking1.9.1?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: