Closed
Bug 461640
Opened 16 years ago
Closed 15 years ago
Box objects should participate in cycle collection
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: peterv, Assigned: smaug)
References
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Had this lying around, got reminded of it by the patch in bug 335998.
|
Reporter | |
Comment 1•15 years ago
|
||
Reassigning this to smaug, since I'll use this to review the boxobject CC changes from the patch in bug 335998.
Assignee: peterv → Olli.Pettay
Blocks: strongparent
|
|
Reporter | |
Comment 2•15 years ago
|
||
These are changes copied from attachment 393225 [details] [diff] [review]. r+ if you address the comments below.
-Please use NS_IMPL_CYCLE_COLLECTION_[0-4] where possible.
-In general we try to keep the CC macros together and the QI/ADDREF/RELEASE together. Where possible, please keep NS_IMPL_CYCLE_COLLECTION_CLASS, unlink and traverse together (which should also undo the moving of AddRef/Release vs QI in some of the files).
Attachment #344747 -
Attachment is obsolete: true
Attachment #395392 -
Flags: review+
|
|
Reporter | |
Comment 3•15 years ago
|
||
We should also do this, boxobjects hold properties which often end up holding JS objects. I didn't add unlinking in case something needs a property from a boxobject after it's unlinked, probably unlikely but I'm paranoid ;-).
Attachment #395393 -
Flags: review?(Olli.Pettay)
|
Assignee | |
Updated•15 years ago
|
Attachment #395393 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
|
|
Assignee | |
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c9565167a523
http://hg.mozilla.org/mozilla-central/rev/6de44038f10b
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•