Closed
Bug 461731
Opened 16 years ago
Closed 16 years ago
use bit for which CSS properties separate value lists with commas rather than spaces
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We should use a bit for which CSS properties separate value lists with commas rather than spaces. There are only four right now, but multiple backgrounds (bug 322475) will add a whole bunch more.
(I haven't had a chance to compile the patch yet.)
|
Assignee | |
Updated•16 years ago
|
Attachment #344840 -
Flags: superreview?(bzbarsky)
Attachment #344840 -
Flags: review?(bzbarsky)
|
||
Updated•16 years ago
|
Attachment #344840 -
Flags: superreview?(bzbarsky)
Attachment #344840 -
Flags: superreview+
Attachment #344840 -
Flags: review?(bzbarsky)
Attachment #344840 -
Flags: review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 344840 [details] [diff] [review]
patch
This looks ok, but it might also be nice to have an nsCSSProps::PropHasFlag(nsCSSProperty, flagname) static method that encapsulates the kFlagsTable access and '&' and such.
|
|
Assignee | |
Comment 2•16 years ago
|
||
OK, but I made it PropHasFlags.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Fixed:
http://hg.mozilla.org/mozilla-central/rev/3821fee89ecd
http://hg.mozilla.org/mozilla-central/rev/d8ed12af2432
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•