Closed
Bug 461736
Opened 16 years ago
Closed 16 years ago
Fix geolocation prompt in Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dougt, Assigned: dougt)
References
Details
Attachments
(3 files)
Recently 459893 change the way geolocation prompts worked. We need to update the geolocation prompt work in fennec.
Comment 2•16 years ago
|
||
Interaction flow for two cases -- when the device (mobile device, laptop, desktop computer) has some ability to know its location (whether by gps, cell-tower association, or known wifi locations), and one where the device just can't know (most likely in the case of a wired-ethernet desktop PC. The latter case assumes that there's still a network connection, which seems reasonable, given that the user is doing something with the web. We need the network connection so that fennec/firefox can turn the user-entered info into coordinates.
Assignee | ||
Comment 3•16 years ago
|
||
madhava, do you have any new mockups based on our last discussion?
Comment 6•16 years ago
|
||
Comment on attachment 362952 [details] [diff] [review] patch v.1 >diff --git a/components/Makefile.in b/components/Makefile.in > EXTRA_COMPONENTS = \ > aboutFirstrun.js \ >+ geolocation-prompt.js \ Can we rename the file to geolocationPrompt.js (yes, I'm anal) >diff --git a/components/geolocation-prompt.js b/components/geolocation-prompt.js >+ label: browserBundle.GetStringFromName("geolocation.exactLocation"), >+ accessKey: browserBundle.GetStringFromName("geolocation.exactLocationKey"), >+ callback: function() request.allow() , Remove trailing comma >+ label: browserBundle.GetStringFromName("geolocation.nothingLocation"), >+ accessKey: browserBundle.GetStringFromName("geolocation.nothingLocationKey"), >+ callback: function() request.cancel() , Remove trailing comma >+ notificationBox.appendNotification(message, >+ "geolocation", >+ "chrome://browser/skin/Info.png", >+ notificationBox.PRIORITY_INFO_HIGH, >+ buttons); >+ } >+ }, Remove trailing comma
Attachment #362952 -
Flags: review+
Assignee | ||
Comment 7•16 years ago
|
||
patch v.1 was checked in: a9713858b4ec This provides us with a simple UI - similar to firefox - to manage geolocation requests.
Assignee | ||
Comment 8•16 years ago
|
||
this is fixed. new design of this prompt should be done in bug 463235 per madhava.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•16 years ago
|
||
Comment on attachment 362951 [details]
basic geolocation prompt (similar to FF)
clearing review flag
Attachment #362951 -
Flags: review?(mark.finkle)
Updated•15 years ago
|
Flags: in-litmus?
Comment 11•15 years ago
|
||
We have these testcases located in litmus. Ids are: 7651-7654
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•