A few nits from nsDocAccessible.h: >+ * Fire accessible event in timeout. Either "with timeout" or "after timeout". >+ * accessible children and and remove the accessible object and any decendents "and and" is doubled, and should be "descendants". >+ * Proccess the case when anchor was clicked. "process" >+ * Used to flush pending events, called in timeout. See FlushPendingEvents. Also "with timeout" or "after timeout". >+ * Iterates through sub documents and shutdowns them. "shuts them down".

thanks, Marco. I fixed this locally.

Comment on attachment 384820 [details] [diff] [review] patch cancelling review since some things become broken.

Comment on attachment 384828 [details] [diff] [review] patch2 r=me for the functional part. This one doesn't break NVDA like the first one did.

Comment on attachment 384828 [details] [diff] [review] patch2 >+ nsRefPtr<nsDocAccessible> docAcc = >+ nsAccUtils::QueryAccessibleDocument(accessibleDoc); >+ if (!docAcc) > return NS_OK; >- } >- return privateAccessibleDoc->FireAnchorJumpEvent(); >+ >+ docAcc->FireAnchorJumpEvent(); >+ return NS_OK; More easily written as: nsRefPtr<nsDocAccessible> docAcc = nsAccUtils::QueryAccessibleDocument(accessibleDoc); if (docAcc) docAcc->FireAnchorJumpEvent(); return NS_OK; (Similarly for some of the following methods.) >+#define NS_INTERFACE_MAP_STATIC_AMBIGUOUS(_class) \ >+ if (aIID.Equals(NS_GET_IID(_class))) { \ >+ NS_ADDREF(this); \ >+ *aInstancePtr = this; \ >+ return NS_OK; \ >+ } else There seems to be a number of approaches to this! It might be worth filing an XPCOM bug on creating a consistent version.

Comment on attachment 384828 [details] [diff] [review] patch2 r=me, I have no additional comments.

checked in with Neil's comment addressed on 1.9.2 - http://hg.mozilla.org/mozilla-central/rev/662379876512

(In reply to comment #7) > There seems to be a number of approaches to this! > It might be worth filing an XPCOM bug on creating a consistent version. I filed bug 500347.