Aaron Leventhal Reporter
	Description • 16 years ago

Go to a site with a feed such as:
http://www.marcozehe.de

First problem -- how does a keyboard-only user view the feed? (This part may be a dupe from an old bug)

Click on the feed icon.

Second problem -- tab navigation is broken. The tab cycle only contains the XUL combobox in it, and nothing else. And the second round of tabbing through does not visit anything in the content at all.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 1 • 16 years ago

I ran a few xul tests and it seems to be the menu popup that is breaking things. I added a dependency (bug 348830) since it might be related, and the test case on that example exhibits similar tab nav breakage on the second round of tabbing.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 2 • 16 years ago

(In reply to comment #0)
> Go to a site with a feed such as:
> http://www.marcozehe.de
> 
> First problem -- how does a keyboard-only user view the feed? (This part may be
> a dupe from an old bug)

There is a menu item "Subscribe to This Page" under Bookmarks.

If we want to put the URL bar icons in the tab order it should be straight forward. In browser/themes/pinstripe/browser/browser.css we could add a style to urlbar-icons like this:

 #urlbar-icons {
+  moz-user-focus: normal;
 
In browser/base/content/browser.xul we might want to that "-moz-user-focus: none" on the feed-button menu.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 3 • 16 years ago

I think this is WONTFIX, actually.

Back when Mark Pilgrim was working on this stuff, he and I agreed that the Bookmarks menuItem was the best way to do accessible feed subscription stuff. Once you enter that UI, you don't get into the bit where you need to do tabbing.

	Marco Zehe (:MarcoZ)
	Comment 4 • 16 years ago

I disagree. This was working perfectly in Firefox 3.0.x. E. G., you go to www.marcozehe.de, choose Bookmarks/Subscribe to this page, and could then navigate the upcoming page using the keyboard (e. g. select a different feed subscription application from the combobox). This is a Firefox 3.1 regression in keyboard navigation. Re-requesting blocking.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 5 • 16 years ago

Ah, then what you're saying is that the first problem from comment 0 is not the issue here, it's the second.

Updating summary, --> RSS Discovery & Preview, asking for regression range.

	Dão Gottwald [:dao]
	Comment 6 • 16 years ago

(In reply to comment #4)
> This was working perfectly in Firefox 3.0.x.

That would surprise me. This seems to have regressed between 2007-08-15-05 and 2007-08-16-05.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-08-15+05%3A00%3A00&maxdate=2007-08-16+05%3A00%3A00&cvsroot=%2Fcvsroot

	Neil Deakin
	Comment 7 • 16 years ago

The tab navigation issue looks like bug 399427. There was a hacky workaround posted in the xul newsgroup recently.

	Shawn Wilsher :sdwilsh
	Comment 8 • 16 years ago

(In reply to comment #7)
> The tab navigation issue looks like bug 399427. There was a hacky workaround
> posted in the xul newsgroup recently.
I looked at mozilla.dev.tech.xul and didn't see it.  It's possibly I wasn't looking close enough at all the posts though.  Care to point it out?

	Neil Deakin
	Comment 9 • 16 years ago

The workaround is to do:

function menulistFocused(menulist) {
  var range = document.createRange();
  range.selectNode(menulist);
  var selection = window.getSelection();
  selection.addRange(range);
  selection.collapseToStart();
}

<menulist onfocus="setTimeout(menulistFocused, 0, this)">

	Neil Deakin
	Comment 10 • 16 years ago

In fact, you could probably get by just using:

<menulist onfocus="setTimeout(function() getSelection().removeAllRanges(), 0)">

	David Dahl :ddahl Assignee
	Comment 11 • 16 years ago

This (code from comment #10) appears to work, however you can only tab focus the menulist one time, as you tab through the rest of the content and back to the urlbar, you cannot tab back into the menulist. Any more ideas? This is still a bit voodoo to me:)

	David Dahl :ddahl Assignee
	Comment 12 • 16 years ago

Now that I have read some of the back story on this bug via the "depends on" bugs, I am thinking you could fix this easily enough if the subscribe page is converted to a XUL window instead of XHTML. What is the rationale for using XHTML w/ XUL inside for this markup/window/functionality?

	David Dahl :ddahl Assignee
	Comment 13 • 16 years ago

I don't want to open up a can of worms by questioning the XUL in XHTML display of the subscribe window, (yet:)) so after applying the proposed patch in comment 9, and testing on  Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090204 Minefield/3.2a1pre, it seems to work. cool.

	Marco Bonardo [:mak]
	Comment 15 • 16 years ago

Comment on attachment 360597 [details] [diff] [review]
Proposed patch from comment 9

sorry, i'm not a valid peer to review this. sayrer is probably better (or can forward you to a valid peer for this component).

	David Dahl :ddahl Assignee
	Comment 16 • 16 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=399427#c30 

Perhaps when the above bug is fixed we will need to back out this change? (thanks Mak77)

	Neil Deakin
	Comment 17 • 16 years ago

Comment on attachment 360597 [details] [diff] [review]
Proposed patch from comment 9

>+  // Work around for menulist XUL in XHTML bug 461981
>+  menuListFocused: function SH_menulistFocused(menulist) {
>+    var range = document.createRange();
>+    range.selectNode(menulist);
>+    var selection = window.getSelection();
>+    selection.addRange(range);
>+    selection.collapseToStart();
>   }
>+
> };
>+
>+

Remove all these extra blank lines and this is ok.

	Dão Gottwald [:dao]
	Comment 18 • 16 years ago

Can we please land this on branch but not on trunk and leave this bug open in favor of bug 399427?

	David Dahl :ddahl Assignee
	Comment 20 • 16 years ago

Does this need approval from a module owner for "branch only" checkin?

	Dão Gottwald [:dao]
	Comment 21 • 16 years ago

No approval needed.

	Dão Gottwald [:dao]
	Comment 22 • 16 years ago

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f698d68ee063

	Neil Deakin
	Comment 23 • 16 years ago

Bug 399427 is fixed now so this should be fixed

	Dão Gottwald [:dao]
	Comment 24 • 16 years ago

I'm going to back this out from 1.9.1 when bug 399427 lands there.