Closed
Bug 462082
Opened 16 years ago
Closed 16 years ago
Update libtheora to 1.0 release version
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: cajbir, Assigned: cajbir)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
The latest libtheora version is Theora 1.0 RC2. The 1.0 release is expected in a matter of days. Currently we use libtheora-1.0beta3.
We should update to the release version to get recent bug fixes and performance enhancements (including ASM support on Windows).
Assignee | ||
Comment 1•16 years ago
|
||
Tested on Linux. Need to test on Mac and Win32.
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
Comment 2•16 years ago
|
||
Chris, did this happen? Do we want to make sure it does before we ship?
Assignee | ||
Comment 3•16 years ago
|
||
It hasn't happened yet but will for two things:
1) Pick up the optimized assembly to for Windows platforms for improved playback. Currently windows playback is not as good as Linux or Mac.
2) Pick up security bug fixes.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Assignee | ||
Comment 4•16 years ago
|
||
Updates to libtheora 1.0 final. Tested on Linux. Need to test on Mac, Windows and tweak config settings so windows uses assembly.
Attachment #345211 -
Attachment is obsolete: true
Assignee | ||
Comment 5•16 years ago
|
||
Tested on Windows, Mac OS X and Linux
Attachment #357237 -
Attachment is obsolete: true
Assignee | ||
Comment 6•16 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/53a4746eb1ba
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [baking for 1.9.1]
Comment 7•16 years ago
|
||
Seems that several (if not all) videos are crashing now (Windows XP).
Assignee | ||
Comment 8•16 years ago
|
||
Ria, can you provide details on the machine you are getting crashes on? In particular, what CPU does it have?
Comment 9•16 years ago
|
||
Adding my comments from the IRC channel, I also crash:
CPU is a 1.4gzh Athlon Thunderbird chip (non-sse)
Vista HP SP1
Nvidia 7300gt 512meg Video card
1 gig pc-133 ram
Comment 10•16 years ago
|
||
(In reply to comment #8)
> Ria, can you provide details on the machine you are getting crashes on? In
> particular, what CPU does it have?
Intel Centrino vPro. It crashes also on XP. And the oldie has a Mobile AMD Athlon XP 2000+.
Comment 11•16 years ago
|
||
Also a crash on Vista which has a Intel Core 2 Duo T5500 processor. Non of the crashes trigger breakpad.
Comment 12•16 years ago
|
||
I can confirm this crash too. Crash occurs immediately on clicking the OGG video link. No crash reporter. This one needed WinDbg to get a stack.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre ID:20090122033712
P3 933MHz + Win XP SP3
STACK TRACE----------------------------------------------------------------------
ModLoad: 76b10000 76b15000 C:\WINDOWS\system32\ctwdm32.dll
ModLoad: 5ad70000 5ada8000 C:\WINDOWS\system32\uxtheme.dll
ModLoad: 59a60000 59b01000 C:\WINDOWS\system32\dbghelp.dll
ModLoad: 006d0000 006d9000 C:\WINDOWS\system32\PGPhk.dll
ModLoad: 006f0000 006f4000 C:\Program Files\Utilities\Unlocker\UnlockerHook.dll
ModLoad: 77920000 77a13000 C:\WINDOWS\system32\SETUPAPI.dll
ModLoad: 76fd0000 7704f000 C:\WINDOWS\system32\CLBCATQ.DLL
ModLoad: 77050000 77115000 C:\WINDOWS\system32\COMRes.dll
ModLoad: 01290000 01298000 C:\Program Files\Internet\firefox\components\browserdirprovider.dll
ModLoad: 71a50000 71a8f000 C:\WINDOWS\system32\mswsock.dll
ModLoad: 662b0000 66308000 C:\WINDOWS\system32\hnetcfg.dll
ModLoad: 71a90000 71a98000 C:\WINDOWS\System32\wshtcpip.dll
ModLoad: 76d60000 76d79000 C:\WINDOWS\system32\iphlpapi.dll
ModLoad: 76f20000 76f47000 C:\WINDOWS\system32\DNSAPI.dll
ModLoad: 76fb0000 76fb8000 C:\WINDOWS\System32\winrnr.dll
ModLoad: 76f60000 76f8c000 C:\WINDOWS\system32\WLDAP32.dll
ModLoad: 73ce0000 73d00000 C:\WINDOWS\system32\t2embed.dll
ModLoad: 73dc0000 73dc3000 C:\WINDOWS\system32\LZ32.dll
ModLoad: 01e00000 020c5000 C:\WINDOWS\system32\xpsp2res.dll
ModLoad: 022d0000 022d7000 C:\Program Files\Utilities\Volumouse\vlmshlp.dll
ModLoad: 022e0000 02303000 C:\Program Files\Internet\firefox\components\brwsrcmp.dll
ModLoad: 02bd0000 02bf6000 C:\Program Files\Internet\firefox\softokn3.dll
ModLoad: 03100000 03118000 C:\Program Files\Internet\firefox\nssdbm3.dll
ModLoad: 03120000 0315d000 C:\Program Files\Internet\firefox\freebl3.dll
ModLoad: 76fc0000 76fc6000 C:\WINDOWS\system32\rasadhlp.dll
ModLoad: 03160000 031a7000 C:\Program Files\Internet\firefox\nssckbi.dll
ModLoad: 77690000 776b1000 C:\WINDOWS\system32\NTMARTA.DLL
ModLoad: 71bf0000 71c03000 C:\WINDOWS\system32\SAMLIB.dll
ModLoad: 73b30000 73b45000 C:\WINDOWS\system32\mscms.dll
ModLoad: 7e290000 7e401000 C:\WINDOWS\system32\shdocvw.dll
ModLoad: 77a80000 77b15000 C:\WINDOWS\system32\CRYPT32.dll
ModLoad: 77b20000 77b32000 C:\WINDOWS\system32\MSASN1.dll
ModLoad: 754d0000 75550000 C:\WINDOWS\system32\CRYPTUI.dll
ModLoad: 5b860000 5b8b5000 C:\WINDOWS\system32\NETAPI32.dll
ModLoad: 771b0000 7725a000 C:\WINDOWS\system32\WININET.dll
ModLoad: 76c30000 76c5e000 C:\WINDOWS\system32\WINTRUST.dll
ModLoad: 76c90000 76cb8000 C:\WINDOWS\system32\IMAGEHLP.dll
ModLoad: 74e30000 74e9d000 C:\WINDOWS\system32\RichEd20.dll
ModLoad: 76360000 76370000 C:\WINDOWS\system32\winsta.dll
(318.c70): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
eax=ffffeda0 ebx=fffffd60 ecx=dcb49e7b edx=04751370 esi=04398000 edi=00000000
eip=104177a8 esp=fffffd60 ebp=046feea4 iopl=0 nv up ei pl zr na pe nc
cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00010246
xul!oc_state_frag_recon_mmx+0x1052:
104177a8 5b pop ebx
0:016> kp
ChildEBP RetAddr
046feea4 00000000 xul!oc_state_frag_recon_mmx(struct oc_theora_state * _state = <Memory access error>, struct oc_fragment * _frag = <Memory access error>, int _pli = <Memory access error>, short * _dct_coeffs = <Memory access error>, int _last_zzi = <Memory access error>, int _ncoefs = <Memory access error>, unsigned short _dc_iquant = <Memory access error>, unsigned short * _ac_iquant = <Memory access error>)+0x1052 [e:\builds\moz2_slave\mozilla-central-win32-nightly\build\media\libtheora\lib\dec\x86_vc\mmxstate.c @ 165]
Assignee | ||
Comment 13•16 years ago
|
||
Thanks for the stack trace. I've raised bug 474937 for this issue.
No longer blocks: 474937
Assignee | ||
Comment 14•16 years ago
|
||
Tryserver builds with assembler routines disabled on windows:
https://build.mozilla.org/tryserver-builds/2009-01-24_18:37-cdouble@mozilla.com-1232850976/
If someone with a machine that gets the crashes could test this it would be much appreciated.
Comment 15•16 years ago
|
||
(In reply to comment #14)
> If someone with a machine that gets the crashes could test this it would be
> much appreciated.
WFM with the linked Tryserver build.
Assignee | ||
Comment 16•16 years ago
|
||
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bd07436d544e
Keywords: fixed1.9.1
Whiteboard: [baking for 1.9.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•