Closed
Bug 462084
Opened 16 years ago
Closed 16 years ago
Add State.prototype.get to esp.js
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jorendorff, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
state.get(var_decl) -> abstract value
Return the union of all possible values of the given variable at this state.
Attachment #345214 -
Flags: review?(dmandelin)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 345214 [details] [diff] [review]
v1
The fragility of our strategy for composing meet and join functions kind of scares me. I don't think we need to fix it yet, but please add a comment giving the preconditions for the zero_nonzero join function before pushing.
Attachment #345214 -
Flags: review?(dmandelin) → review+
|
Reporter | |
Comment 2•16 years ago
|
||
This is what you meant, right?
function join(v1, v2) {
+ // Here we can assume that v1 != v2 and neither is TOP or NOT_REACHED.
if (v1 == 0 || v2 == 0) return ESP.TOP;
return Lattice.NONZERO;
}
http://hg.mozilla.org/users/tglek_mozilla.com/dehydra-gcc/rev/125235b5a9aa
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 3•16 years ago
|
||
The version I pushed has a shorter implementation of esp.js's join() function because dmandelin pointed out that NOT_REACHED will never be passed there.
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•