Closed Bug 462223 Opened 16 years ago Closed 16 years ago

Update welcome_help (no search sidebar anymore)

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: stefanh, Assigned: stefanh)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch welcome_help update (deleted) — Splinter Review
Bug 460668 removed the search sidebar - it's still mentioned in the welcome page. I also removed the contentsbox that hold the (last time changed?) date. Then I changed the copyright string from "Contributors to the Mozilla Help Viewer Project" to "Contributors to the Mozilla project". Most important here is to change the text about the search sidebar, though. I did talked to Gerv about the "Contributors to the Mozilla project" string for quite some time ago. I seem to have lost the e-mail, but iirc Gerv prefered "Contributors to the Mozilla project". It's no big deal, but maybe the "Mozilla Help Viewer Project" is a bit too specific, especially now when there is no such project. Steffen, not sure if you're the appropriate reviewer for this nowadays - if you're not, feel free to bump this to someone else.
Attachment #345349 - Flags: review?(steffen.wilberg)
Comment on attachment 345349 [details] [diff] [review] welcome_help update Oh, wait - maybe Waldo can look at this.
Attachment #345349 - Flags: review?(steffen.wilberg) → review?(jwalden+bmo)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9.1b2
Gerv, would you mind commenting here regarding the copyright line mentioned in comment #0?
I'd prefer "Contributors to the Mozilla project" - we're all one big, happy family after all :-) Gerv
Attachment #345349 - Flags: review?(jwalden+bmo) → review?(gavin.sharp)
Comment on attachment 345349 [details] [diff] [review] welcome_help update Maybe gavin could look at this. I think it's reasonable to ship a correct default help start page, even though I'm unsure if anyone uses it.
Attachment #345349 - Flags: review?(gavin.sharp) → review+
Pushed changeset ca880b3ff7fc to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1b2 → mozilla1.9.2a1
Pushed changeset 3138b5986b11 to mozilla-1.9.1
Keywords: fixed1.9.1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
Target Milestone: mozilla1.9.1b3 → mozilla1.9.2a1
Serge Gautherie changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|mozilla1.9.2a1 |mozilla1.9.1b3 JFTR: I changed this back because: This was first landed on mozilla-central (current "trunk"), so the target milestone should be "mozilla1.9.2a1". Then it was landed on mozilla-1.9.1, thus the keyword "fixed1.9.1".
(In reply to comment #7) Ah. I'm more used to set it to the lowest version in which a bug gets fixed... (especially currently when the fixed1.9.1 serves as an implicit fixed1.9.1b3.)
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: