Closed
Bug 462338
Opened 16 years ago
Closed 16 years ago
Make executeSoon widely available
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
|
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
This creates SimpleTest.executeSoon, copying it from the download tests. I'm not sure though whether we can edit SimpleTest or not.
The two tests I updated seem to be happyish. One of them shows two failures with or without my patch so I'm not sure what that is all about.
Ben you seem to be a peer for this, what say you?
Attachment #345481 -
Flags: review?(bhearsum)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 345481 [details] [diff] [review]
patch rev 1
Huh. I didn't know I was a peer for this. I'm totally not the right person to review this - maybe rob?
Attachment #345481 -
Flags: review?(bhearsum) → review?(rcampbell)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 345481 [details] [diff] [review]
patch rev 1
looks reasonable, no visible nits. Try it out!
Attachment #345481 -
Flags: review?(rcampbell) → review+
|
Assignee | |
Comment 3•16 years ago
|
||
Forgot to add this to browser chrome too, this is just an addition to the previous patch.
|
||
Updated•16 years ago
|
Attachment #345486 -
Flags: review?(rcampbell) → review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed both patches: http://hg.mozilla.org/mozilla-central/rev/46a0fed0b3df
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•16 years ago
|
||
Landed on the 1.9 branch too.
|
|
Assignee | |
Updated•16 years ago
|
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.2a1
|
||
Updated•15 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•