Closed Bug 462368 Opened 16 years ago Closed 16 years ago

Controls should always be visible for a <video> element without a video track

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: roc, Assigned: Dolske)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

When a <video controls> element is playing a stream with no video track, it can be hard to see where the element is so you can mouse over it to show the controls. In that case, we may as well always show the controls. Maybe the controls binding can check the videoWidth/videoHeight and always show the controls if they're 0,0?
bkap just noted that this happens on Wikipedia, when clicking a link for an audio file... 1) http://en.wikipedia.org/wiki/Hertfordshire 2) Click "listen" (top of intro paragraph) 3) http://upload.wikimedia.org/wikipedia/en/e/ea/UK-Herts.ogg We just create a nsVideoDocument for this, and there's probably no way to determine ahead of time that it should really be an <audio>. This should be easy to fix in the controls.
Assignee: nobody → dolske
Target Milestone: --- → mozilla1.9.2a1
Blocks: TrackAVUI
Attached patch Patch v.1 (deleted) — Splinter Review
Attachment #365793 - Flags: review?(enndeakin)
Attachment #365793 - Flags: review?(enndeakin) → review+
Comment on attachment 365793 [details] [diff] [review] Patch v.1 a191=beltzner It'd be good to get that test URL written into a Litmus case and in-litmus? added here, I think.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Steps for Litmus testing: 1) Directly load a audio-only OGG. Wikipedia has lots. For example: http://upload.wikimedia.org/wikipedia/commons/7/74/Schubert-D.935-2.ogg 2) Media should begin playing 3) Controls should be visible without needing to move the mouse over the upper-left area of the page. Moving the mouse in and out of this area shouldn't do anything (controls should stay visible). In a current build *without* this patch, the controls are only shown when the mouse is over the media element. Note that on really slow connections you might notice a slight initial delay before the controls are faded in and playback starts.
Flags: in-litmus?
Thanks Justin for the testcase. Added Fx3.1 litmus test: https://litmus.mozilla.org/show_test.cgi?id=7603
Flags: in-litmus? → in-litmus+
Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090311 Minefield/3.2a1pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090311 Minefield/3.2a1pre. Verified fixed on the branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090311 Shiretoko/3.1b4pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090311 Shiretoko/3.1b4pre
Status: RESOLVED → VERIFIED
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: