Closed
Bug 462432
Opened 16 years ago
Closed 16 years ago
Leak mAsyncExecutionMutex
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: sdwilsh, Assigned: asuth)
References
Details
(Keywords: fixed1.9.1, memory-leak, Whiteboard: [tb3needs])
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
beltzner
:
approval1.9.1b2-
|
Details | Diff | Splinter Review |
We currently leak mAsyncExecutionMutex added in bug 460635. I missed this in my review.
|
Assignee | |
Comment 1•16 years ago
|
||
This corrects the leak. nsAutoLock is an unusual mutex abstraction... I also neglected to NS_ENSURE_TRUE as is done for the other mutexes, so we do that too now.
Attachment #346330 -
Flags: review?(sdwilsh)
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init
r=sdwilsh
Attachment #346330 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Marking for check-in. This passed linux/linux talos/OS X try-server; windows had unrelated bustage and windows talos failed to run.
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Attachment #346330 -
Flags: approval1.9.1b2?
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 4•16 years ago
|
||
Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init
Limiting the number of checkins required before we can finish this beta. We'll get this after.
Attachment #346330 -
Flags: approval1.9.1b2? → approval1.9.1b2-
|
||
Updated•16 years ago
|
Whiteboard: [tb3needs]
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 346330 [details] [diff] [review]
v1 don't leak the async execution mutex, also verify its existence at init
a191=beltzner
Attachment #346330 -
Flags: approval1.9.1+
|
|
Reporter | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 7•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1b2 → mozilla1.9.1b3
|
|
Reporter | |
Updated•16 years ago
|
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•