Closed Bug 462440 Opened 16 years ago Closed 16 years ago

Frequent build failures "error: nsICanvasElement.h: No such file or directory"

Categories

(Firefox Build System :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.9.1b2

People

(Reporter: standard8, Assigned: benjamin)

References

Details

(Keywords: regression)

Attachments

(2 files)

Since the landing of bug 461395 we've seen frequent (well, maybe occasional depending on your point of view) build failures on the Thunderbird Linux and Windows unit test boxes.

I'm not sure its been seen anywhere else yet, but our boxes do cycle much faster than Firefox/other trees.

The error is consistent:

nsBaseDragService.cpp
d:/buildbot/trunk-win32/build/mozilla/widget/src/xpwidgets/nsBaseDragService.cpp(64) : fatal error C1083: Cannot open include file: 'nsICanvasElement.h': No such file or directory
make[8]: Leaving directory `/d/buildbot/trunk-win32/build/objdir-tb/mozilla/widget/src/xpwidgets'

Some logs where it has failed:

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1225405371.1225405444.8414.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1225402335.1225402931.1274.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1225395277.1225395819.14037.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225391922.1225394107.9378.gz
Win2k3 comm-central dep unit test on 2008/10/30 11:38:42

***

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225406758.1225407822.13883.gz
Win2k3 comm-central dep unit test on 2008/10/30 15:45:58

followed by similar errors:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225407447.1225408019.14301.gz
Win2k3 comm-central dep unit test on 2008/10/30 15:57:27
d:/builds/slave/comm-central-win32/build/mozilla/intl/chardet/src/nsDetectionAdaptor.cpp(44) : fatal error C1083: Cannot open include file: 'nsIDocument.h': No such file or directory

then

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1225407658.1225408312.15182.gz
Win2k3 comm-central dep unit test on 2008/10/30 16:00:58
d:/builds/slave/comm-central-win32/build/mozilla/content/canvas/src/nsCanvasRenderingContext2D.cpp(53) : fatal error C1083: Cannot open include file: 'nsICanvasRenderingContextInternal.h': No such file or directory
d:/builds/slave/comm-central-win32/build/mozilla/content/html/content/src/nsHTMLCanvasElement.cpp(57) : fatal error C1083: Cannot open include file: 'nsICanvasElement.h': No such file or directory
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #345625 - Flags: review?(ted.mielczarek)
Attachment #345625 - Flags: review?(ted.mielczarek) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/4e0ec220c354
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
I pushed the changes to js/src/config/rules.mk as well to fix windows orange.  I assumed this is what we had to do since we had to do it earlier.  Someone feel free to back it out if I'm wrong.
http://hg.mozilla.org/mozilla-central/rev/4e57436f644e
V.Fixed
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.1b2
(In reply to comment #4)
> I pushed the changes to js/src/config/rules.mk as well to fix windows orange. 
> I assumed this is what we had to do since we had to do it earlier.  Someone
> feel free to back it out if I'm wrong.
> http://hg.mozilla.org/mozilla-central/rev/4e57436f644e

Yes, we need to keep the files in mozilla-central/config and js/src/config in sync. We will probably make this mistake several more times until it becomes habit.
Attached patch Remove redundant line (deleted) — Splinter Review
Tested on the try server.
Attachment #346461 - Flags: review?(ted.mielczarek)
Attachment #346461 - Flags: review?(ted.mielczarek) → review+
Attachment #346461 - Flags: approval1.9.1b2?
Attachment #346461 - Flags: approval1.9.1b2? → approval1.9.1b2+
Comment on attachment 346461 [details] [diff] [review]
Remove redundant line

a=beltzner
Pushed changeset 8b3bbc775828 to mozilla-central.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: