Closed
Bug 462650
Opened 16 years ago
Closed 16 years ago
HUD panels: add half diamond arrow on the top of the panel
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: faaborg, Assigned: mstange)
References
Details
(Keywords: verified1.9.1)
Attachments
(6 files, 2 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
faaborg
:
ui-review+
|
Details |
(deleted),
image/png
|
faaborg
:
ui-review+
|
Details |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
beltzner
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
We should add a half diamond arrow on top of the HUD panels in Firelight (site identity, bookmark information). Attached is a rough mockup, this is similar to the contextual menu on dock items, but with the HUD appearance.
The windows counterpart to this is bug 413059, where there is an example patch using SVG instead of -moz-border-image, which might be worth taking a look at. Since we don't have to worry about adapting the appearance of the panel for different OS themes, that approach might be overkill.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•16 years ago
|
||
Assignee | ||
Comment 2•16 years ago
|
||
Attachment #345975 -
Flags: ui-review?(faaborg)
Assignee | ||
Comment 3•16 years ago
|
||
Attachment #345976 -
Flags: ui-review?(faaborg)
Assignee | ||
Comment 4•16 years ago
|
||
I'm not really sure yet if we should really use that gradient at the top of the panel; unlike all the other HUD panels in OS X, our panels don't have a real titlebar. Moreover, the gradient collides with the bookmarks bar gradient in a weird way.
Reporter | ||
Comment 5•16 years ago
|
||
>I'm not really sure yet if we should really use that gradient at the top of the
>panel
Yeah I agree, these will work better without the title bar gradient.
Reporter | ||
Comment 6•16 years ago
|
||
Comment on attachment 345975 [details]
Screenshot: Site identity HUD panel
ui-r+ with the gradient removed from the title bar, size and placement of the half diamond looks good
Attachment #345975 -
Flags: ui-review?(faaborg) → ui-review+
Reporter | ||
Comment 7•16 years ago
|
||
Comment on attachment 345976 [details]
Screenshot: bookmarks HUD panel
ui-r+ with the gradient removed from the title bar, size and placement of the half diamond looks good
Attachment #345976 -
Flags: ui-review?(faaborg) → ui-review+
Assignee | ||
Comment 8•16 years ago
|
||
Attachment #345974 -
Attachment is obsolete: true
Assignee | ||
Comment 9•16 years ago
|
||
Attachment #346034 -
Flags: review?(mconnor)
Assignee | ||
Comment 10•16 years ago
|
||
Attachment #346034 -
Attachment is obsolete: true
Attachment #346041 -
Flags: review?(mconnor)
Attachment #346034 -
Flags: review?(mconnor)
Updated•16 years ago
|
Attachment #346041 -
Flags: review?(mconnor) → review+
Comment 11•16 years ago
|
||
Comment on attachment 346041 [details] [diff] [review]
v1.1, image included
r=beltzner
Comment 12•16 years ago
|
||
This of course is going to completely fail if the window is near the edge of the screen, no?
Assignee | ||
Comment 13•16 years ago
|
||
Oh, yeah... but these panels pop up towards the center of the window, so it's only an issue if the window overlaps the edges of the screen, right?
Reporter | ||
Comment 14•16 years ago
|
||
>This of course is going to completely fail if the window is near the edge of
>the screen, no?
Is there any way to remove the arrow in the case that the panel is being draw in a different position to avoid being drawn off screen? Ideally we could add all sorts of extra logic so we could get the arrow in a variety of positions, like when you right click on a link and say "bookmark this link." But that is of course some significant scope creep.
Assignee | ||
Updated•16 years ago
|
Attachment #346041 -
Flags: approval1.9.1?
Updated•16 years ago
|
Attachment #346041 -
Flags: approval1.9.1? → approval1.9.1+
Comment 15•16 years ago
|
||
Comment on attachment 346041 [details] [diff] [review]
v1.1, image included
a191=beltzner - please test thoroughly after landing and be ready to back out if, as Enn warns, the edge cases overtake the value of this patch.
Comment 16•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3
Updated•16 years ago
|
Keywords: fixed1.9.1
Comment 17•16 years ago
|
||
Yeah, so the attached screenshot shows behavior when the window is close enough to the bottom of the screen that there isn't enough room to keep the HUD panel at the bottom of the button.
Comment 18•16 years ago
|
||
Comment 19•15 years ago
|
||
A bug has been created for this issue with a better screenshot attached to the bug.
Bug link: https://bugzilla.mozilla.org/show_bug.cgi?id=495140
HUD Panel has diamond arrow on both builds:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090527 Minefield/3.6a1pre ID:20090527031500
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090527 Shiretoko/3.5pre ID:20090527031214
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•