neil@parkwaycc.co.uk Assignee
	Description • 16 years ago

i.e. port bug 461395 to comm-central

	neil@parkwaycc.co.uk Assignee
	Comment 1 • 16 years ago

* Ports PARALLEL_DIRS changes
* Hoists makefiles into parent when dir only has subdirs
* Uses PARALLEL_DIRS when more than one subdir to make

	Justin Wood (:Callek)
	Comment 2 • 16 years ago

Comment on attachment 345936 [details] [diff] [review]
Proposed patch

-DIRS = public src
+PARALLEL_DIRS = public src

You have to remember, that if there are ANY deps between dirs in PARALLEL_* we shouldn't use PARALLEL, as we can't be sure "public" idls are exported before "src" needs them... unless I am missing something entirely

	neil@parkwaycc.co.uk Assignee
	Comment 3 • 16 years ago

(In reply to comment #2)
> (From update of attachment 345936 [details] [diff] [review])
> -DIRS = public src
> +PARALLEL_DIRS = public src
> 
> You have to remember, that if there are ANY deps between dirs in PARALLEL_* we
> shouldn't use PARALLEL, as we can't be sure "public" idls are exported before
> "src" needs them... unless I am missing something entirely
I think we only need the .h files which are exported in the export phase.

	Robert Kaiser
	Comment 4 • 16 years ago

Comment on attachment 345936 [details] [diff] [review]
Proposed patch

I still need to test the patch, but please incorporate the bug 462730 patch into rules.mk when doing this.

	Justin Wood (:Callek)
	Comment 5 • 16 years ago

Comment on attachment 345936 [details] [diff] [review]
Proposed patch

I still haven't tested, but ted confirmed that export always finishes before libs is run

	Robert Kaiser
	Comment 6 • 16 years ago

Comment on attachment 345936 [details] [diff] [review]
Proposed patch

r=me with incorporation of the mentioned followup into rules.mk

	neil@parkwaycc.co.uk Assignee
	Comment 7 • 16 years ago

Whoops, forgot to mention that I pushed changeset 7d1219fe35d8 to comm-central.