At NASA, one of their requirements for Bugzilla was that it show people what they searched for, after they ran the search, in some human-readable way. This is kind of handy for people who print out buglists, or when running a shared query. It's also nice when you have a lot of buglists open and you go between them and want to know which darn buglist this is. I'll let consensus determine the usefulness of the feature, but I've implemented it. I removed the old debug data and just converted it into a human-readable format. I also moved the search-type descriptions into field-descs.none.tmpl, which is what most of this patch is. I can split that out into a second patch if you think that would make reviewing easier. Most of the work in Search.pm is done under the $self->$ref call, with just one call to search_description. All of the other calls and changes in Search.pm are to handle special cases that should be using the normal charts but aren't. :-|

Comment on attachment 346223 [details] [diff] [review] v1 Searching for comment contains test doesn't work - it just shows ": test" without anything before the colon. The advanced searches just show as extra items, without any bracketing/grouping, which the previous debug code had. I'm also not sure how popular this will be as a default, but I guess we can try it and see.

(In reply to comment #1) > The advanced searches just show as extra items, without any > bracketing/grouping, which the previous debug code had. Yes, it's just there to remind you what you searched for, not to be totally comprehensive.

Which is fine, but it loses some of the debugability (if thats a real word....)

(In reply to comment #1) > (From update of attachment 346223 [details] [diff] [review]) > Searching for comment contains test doesn't work - it just shows ": test" > without anything before the colon. What chart are you using? I can't reproduce.

Just the 'a comment' bit at the top of search.pm. The debug=1 output shows its calling into the fulltext table, which may be the issue

Ah, apparently that box was using a strange name for the longdesc field (one that wasn't in field_descs). So I just made them uniform.

Comment on attachment 346875 [details] [diff] [review] v2 The patch does what it says it does, but: (In reply to comment #2) > (In reply to comment #1) > > The advanced searches just show as extra items, without any > > bracketing/grouping, which the previous debug code had. > > Yes, it's just there to remind you what you searched for, not to be totally > comprehensive. For regular users, it may act as an 'oh, yeah, right' if its a bookmark, I guess, but its still confusing/misleading. And for developers, theres no way to debug the search query parsing at all, now, short of reverse engineering the SQL.

We have been using this kind of mod on our bug tracker for a number of months, and it has been pretty helpful. Its all about quick visibility or reminder for what you searched. You always can still go back to the debug output on the buglist page if you need true debugging abilities.

Comment on attachment 346875 [details] [diff] [review] v2 Some of the debug stuff isn't there, but I guess we can try it and get user feedback r=bbaetz

I want justdave's feedback on whether or not we want this (I was funded to implement it, so I'm not an impartial party).

I kinda like having this available as an option. I'd personally rather it not replace the debug stuff though, and just be an additional option.

I'm going to approve this, and if we want to make it a user preference, we can later.

Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.387; previous revision: 1.386 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.167; previous revision: 1.166 done Checking in skins/standard/buglist.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/buglist.css,v <-- buglist.css new revision: 1.14; previous revision: 1.13 done Checking in template/en/default/global/field-descs.none.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/field-descs.none.tmpl,v <-- field-descs.none.tmpl new revision: 1.30; previous revision: 1.29 done Checking in template/en/default/list/list.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v <-- list.html.tmpl new revision: 1.63; previous revision: 1.62 done Checking in template/en/default/search/boolean-charts.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v <-- boolean-charts.html.tmpl new revision: 1.19; previous revision: 1.18 done Checking in template/en/default/search/form.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v <-- form.html.tmpl new revision: 1.55; previous revision: 1.54 done RCS file: /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/type-select.html.tmpl,v done Checking in template/en/default/search/type-select.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/type-select.html.tmpl,v <-- type-select.html.tmpl initial revision: 1.1 done

008filter.t fails. This patch fixes errors reported. Checking in template/en/default/filterexceptions.pl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v <-- filterexceptions.pl new revision: 1.122; previous revision: 1.121 done Checking in template/en/default/search/type-select.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/search/type-select.html.tmpl,v <-- type-select.html.tmpl new revision: 1.2; previous revision: 1.1 done

Added to the release notes for Bugzilla 3.4 in bug 494037.