Closed
Bug 463363
Opened 16 years ago
Closed 16 years ago
ctrlTab event handler should ignore events from nested popups, e.g. context menus
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 3.1b2
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: blocking-firefox3.1?
Attachment #346626 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•16 years ago
|
Summary: ctrlTab event handler should ignore events of nested popups, e.g. context menus → ctrlTab event handler should ignore events from nested popups, e.g. context menus
|
||
Comment 1•16 years ago
|
||
Beta 2 can go out without this, but blocks final.
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Target Milestone: --- → Firefox 3.1
|
||
Comment 2•16 years ago
|
||
Beltzner, on OS X this is probably the cause for the crasher I've reported in bug 463285. If it's not in b2 we could expect a lot of crash reports.
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> on OS X this is probably the cause for the crasher I've reported in
> bug 463285.
I don't think what the code currently does should cause a crash.
|
||
Comment 4•16 years ago
|
||
(In reply to comment #3)
I agree, and have assigned bug 463285 to myself.
I'll get to work on it as soon as I can figure out how to reproduce
it.
|
||
Updated•16 years ago
|
Attachment #346626 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3.1 → Firefox 3.1b2
|
|
||
Comment 6•16 years ago
|
||
So will this fix get into beta2? Or has the 1.9.1 branch already been created.
|
|
Assignee | |
Comment 7•16 years ago
|
||
(In reply to comment #6)
> So will this fix get into beta2?
Yes
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
||
Comment 8•16 years ago
|
||
|
|
||
Comment 9•15 years ago
|
||
verified FIXED on builds:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2 ID:20081201061100
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090517 Shiretoko/3.5b5pre ID:20090517031745
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•