Building on Win32 with VC8sp1, make -j2, my build broke in xpcom/tests: TestStringAPI.cpp Building deps for /d/build/mozilla-central/xpcom/tests/TestStringAPI.cpp link -nologo -out:nsIFileEnumerator.exe -pdb:nsIFileEnumerator.pdb nsIFileEnumer ator.obj -NXCOMPAT -SAFESEH -DYNAMICBASE -MANIFEST:NO -DEBUG -OPT:REF -OPT:now in98 ../../dist/lib/xpcomglue_s.lib d:/build/obj-firefox-opt-libxul/dist/lib/x pcom.lib d:/build/obj-firefox-opt-libxul/dist/lib/xul.lib d:/build/obj-firefox-o pt-libxul/dist/lib/nspr4.lib d:/build/obj-firefox-opt-libxul/dist/lib/plc4.lib d :/build/obj-firefox-opt-libxul/dist/lib/plds4.lib kernel32.lib user32.lib gdi 32.lib winmm.lib wsock32.lib advapi32.lib cl -FoTestStringAPI.obj -c -DOSTYPE=\"WINNT5.1\" -DOSARCH=WINNT -I/d/build/mozi lla-central/xpcom/tests/../ds -I/d/build/mozilla-central/xpcom/tests/services - I/d/build/mozilla-central/xpcom/tests -I. -I../../dist/include/string -I../../di st/include -I../../dist/include/xpcom -Id:/build/obj-firefox-opt-libxul/dist/i nclude/nspr -Id:/build/obj-firefox-opt-libxul/dist/sdk/include -GR- -T P -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -EHsc -MD -D_CRT_SECURE_NO_DEPRECATE=1 -D_CRT_NONSTDC_NO _DEPRECATE=1 -DWINVER=0x500 -D_WIN32_WINNT=0x500 -D_WIN32_IE=0x0500 -DX_DISPLAY_ MISSING=1 -DMOZILLA_VERSION=\"1.9.1b2pre\" -DMOZILLA_VERSION_U=1.9.1b2pre -DHAVE _SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREA DS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -DHAVE_MMINTRIN_H=1 -DH AVE_OLEACC_IDL=1 -DHAVE_ATLBASE_H=1 -DHAVE_WPCAPI_H=1 -D_X86_=1 -DD_INO=d_ino -D MOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVE L_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1 -DMOZ_DEFAUL T_TOOLKIT=\"cairo-windows\" -DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMB IDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 - DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_OGG=1 -DMOZ_ MEDIA=1 -DMOZ_XTF=1 -DMOZ_CRASHREPORTER=1 -DMOZ_CRASHREPORTER_ENABLE_PERCENT=100 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_SVG=1 -DMOZ_UPDATE_CHANNEL=default - DMOZ_PLACES=1 -DMOZ_FEEDS=1 -DMOZ_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLAS SIFIER=1 -DMOZ_LOGGING=1 -DMOZ_MEMORY_SIZEOF_PTR_2POW=2 -DMOZ_MEMORY=1 -DMOZ_MEM ORY_WINDOWS=1 -D_STATIC_CPPLIB=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_ENABLE_LIBXUL= 1 -DMOZ_TREE_CAIRO=1 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_ RDF=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -D_MOZILLA_CONFIG_H_ -DMOZIL LA_CLIENT /d/build/mozilla-central/xpcom/tests/TestStringAPI.cpp TestStringAPI.cpp d:/build/mozilla-central/xpcom/tests/TestStringAPI.cpp : fatal error C1033: cann ot open program database 'd:\build\obj-firefox-opt-libxul\xpcom\tests\generated. pdb' make[5]: *** [TestStringAPI.obj] Error 2 make[5]: *** Waiting for unfinished jobs.... make[5]: Leaving directory `/d/build/obj-firefox-opt-libxul/xpcom/tests' make[4]: *** [tools] Error 2 make[4]: Leaving directory `/d/build/obj-firefox-opt-libxul/xpcom' make[3]: *** [tools_tier_xpcom] Error 2 make[3]: Leaving directory `/d/build/obj-firefox-opt-libxul' make[2]: *** [tier_toolkit] Error 2 make[2]: Leaving directory `/d/build/obj-firefox-opt-libxul' make[1]: *** [default] Error 2 make[1]: Leaving directory `/d/build/obj-firefox-opt-libxul' make: *** [build] Error 2

Please test to make sure this works.

I can't actually reproduce this right now. Not sure what happened there.

I was able to reproduce the issue reliably with VC9 (with SP1). Applying the patch seems to have fixed it.

Comment on attachment 346702 [details] [diff] [review] Use the slow path when SIMPLE_PROGRAMS is set, rev. 1 No-risk

Comment on attachment 346702 [details] [diff] [review] Use the slow path when SIMPLE_PROGRAMS is set, rev. 1 a191=beltzner

Pushed to 1.9.1 - http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f8f3208b2606