Closed Bug 463546 Opened 16 years ago Closed 16 years ago

Permitted to detach an already-detached attachment: can cause data loss.

Categories

(Thunderbird :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 416284

People

(Reporter: keith.dear, Unassigned)

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 Build Identifier: version 2.0.0.17 (20080914) If an attachment has already been detached, and we try to detach it, then: PROBLEM 1 This does NOT lead to a sensible message such as "That attachment has already been detached". Instead, we are prompted for a location to save the non-existent attachment. Only then are we told "unable to save detachment". PROBLEM 2 In the process, an empty (0 bytes) file with the name of the original attachment is created. PROBLEM 3 If that file already existed (most likely because we created it when we first detached the attachment), and we accept replacing it, then IT IS OVERWRITTEN AND LOST. The original attachment then exists nowhere. You might think that's our own fault for accepting "replace". But we might think that we have genuinely been sent a new version of a document that we already had, and we might truly WANT to replace it with the new version. This bug will bite if we try to do that twice with the same message. Reproducible: Always Steps to Reproduce: 1.Detach an attachment, saving it as (say) C:\attach.doc 2.From the same message, do it again, but saving somewhere else 3.From the same message, do it again, but this time replacing C:\attach.doc Actual Results: Step 1 correctly creates a local copy of the attachment. Step 2 above creates am unwanted 0-byte file. Step 3 above ERASES the original saved attachment, making it 0 bytes. Expected Results: Error message "attachment already detached". No empty file created. No existing file erased.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.