Closed
Bug 463595
Opened 16 years ago
Closed 16 years ago
browser_Application.js uses timeouts and fails intermittently
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3.1b2
People
(Reporter: mossop, Assigned: mossop)
References
Details
(Keywords: intermittent-failure, verified1.9.0.5)
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•16 years ago
|
||
Use a proper window open listener to catch the console opening.
Attachment #346865 -
Flags: review?(gavin.sharp)
|
||
Updated•16 years ago
|
Attachment #346865 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 346865 [details] [diff] [review]
patch rev 1
>diff --git a/browser/fuel/test/browser_Application.js b/browser/fuel/test/browser_Application.js
>+function WindowOpenListener(url, opencallback, closecallback) {
Perhaps we should add this helper to the harness?
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> (From update of attachment 346865 [details] [diff] [review])
> >diff --git a/browser/fuel/test/browser_Application.js b/browser/fuel/test/browser_Application.js
>
> >+function WindowOpenListener(url, opencallback, closecallback) {
>
> Perhaps we should add this helper to the harness?
Will look into that elsewhere but might be a good idea.
|
||
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
|
|
||
Comment 5•16 years ago
|
||
I've checked this in on the 1.9.0 branch as well since it was being hit there fairly frequently on the linux boxes.
mozilla/browser/fuel/test/browser_Application.js 1.4
Keywords: fixed1.9.0.5
|
||
Comment 6•16 years ago
|
||
Marking verified for 1.9.0.5 as I see that the test is passing.
Keywords: fixed1.9.0.5 → verified1.9.0.5
|
||
Updated•16 years ago
|
Whiteboard: [orange]
|
||
Updated•12 years ago
|
Keywords: intermittent-failure
|
|
||
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•