Closed Bug 463887 Opened 16 years ago Closed 16 years ago

Building XRemoteCLient is broken on CHINOOK-ARMEL-2007 toolchain

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

ac_add_options --enable-application=xulrunner #* Simple Build ac_add_options --disable-javaxpcom ac_add_options --disable-js-static-build ac_add_options --disable-tests #* Compiler options ac_add_options --disable-pedantic ac_add_options --disable-old-abi-compat-wrappers ac_add_options --disable-crashreporter ac_add_options --disable-mochitest ac_add_options --disable-ogg ac_add_options --disable-svg ac_add_options --disable-mathml ac_add_options --enable-optimize ac_add_options --with-arm-kuser mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-arm-xulrunner mk_add_options MOZ_MAKE_FLAGS=-j9 result: ***************************** make[4]: Leaving directory `obj-arm-xulrunner/toolkit/components' make[4]: Entering directory `obj-arm-xulrunner/widget/src/xremoteclient' XRemoteClient.cpp c++ -o XRemoteClient.o -c -fvisibility=hidden -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -Imozilla-central/widget/src/xremoteclient -I. -I../../../dist/include/xpcom -I../../../dist/include -I../../../dist/include/xremoteclient -Iobj-arm-xulrunner/dist/include/nspr -Iobj-arm-xulrunner/dist/sdk/include -fPIC -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -fno-strict-aliasing -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/XRemoteClient.pp mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp c++ -o XRemoteClient_standalone.o -c -fvisibility=hidden -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -Imozilla-central/widget/src/xremoteclient -I. -I../../../dist/include/xpcom -I../../../dist/include -I../../../dist/include/xremoteclient -Iobj-arm-xulrunner/dist/include/nspr -Iobj-arm-xulrunner/dist/sdk/include -fPIC -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -fno-strict-aliasing -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/XRemoteClient_standalone.pp mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp mozilla-xremote-client.cpp c++ -o mozilla-xremote-client.o -c -fvisibility=hidden -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -Imozilla-central/widget/src/xremoteclient -I. -I../../../dist/include/xpcom -I../../../dist/include -I../../../dist/include/xremoteclient -Iobj-arm-xulrunner/dist/include/nspr -Iobj-arm-xulrunner/dist/sdk/include -fPIC -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -fno-strict-aliasing -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/mozilla-xremote-client.pp mozilla-central/widget/src/xremoteclient/mozilla-xremote-client.cpp mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' rm -f libxremote_client_s.a ar cr libxremote_client_s.a XRemoteClient.o ranlib libxremote_client_s.a mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' mozilla-central/widget/src/xremoteclient/XRemoteClient.cpp:120: warning: deprecated conversion from string constant to 'char*' c++ -o mozilla-xremote-client -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -fno-strict-aliasing -pthread -pipe -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 mozilla-xremote-client.o XRemoteClient_standalone.o -lpthread -Wl,-rpath-link,obj-arm-xulrunner/dist/bin -Wl,-rpath-link,/lib -L../../../dist/bin -L../../../dist/lib -Lobj-arm-xulrunner/dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lX11 -lasound -ldl -lm /scratchbox/compilers/cs2007q3-glibc2.5-arm6/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.1/../../../../arm-none-linux-gnueabi/bin/ld: warning: libXau.so.6, needed by /usr/lib/libX11.so, not found (try using -rpath or -rpath-link) /scratchbox/compilers/cs2007q3-glibc2.5-arm6/bin/../lib/gcc/arm-none-linux-gnueabi/4.2.1/../../../../arm-none-linux-gnueabi/bin/ld: warning: libXdmcp.so.6, needed by /usr/lib/libX11.so, not found (try using -rpath or -rpath-link) /usr/lib/libX11.so: undefined reference to `XauDisposeAuth' /usr/lib/libX11.so: undefined reference to `XauGetBestAuthByAddr' /usr/lib/libX11.so: undefined reference to `XdmcpWrap' collect2: ld returned 1 exit status make[4]: *** [mozilla-xremote-client] Error 1 make[4]: Leaving directory `obj-arm-xulrunner/widget/src/xremoteclient' make[3]: *** [libs_tier_toolkit] Error 2 make[3]: Leaving directory `obj-arm-xulrunner' *****************************
Looks like I need to add ac_add_options --prefix=/usr otherwise it will not find any libraries... I think we should check $(PREFIX) and if it is not defined then use fallback /usr prefix (as most common prefix)
ups, I'm wrong... --prefix=/usr also does not work only direct export to make works: make -f client.mk build_all PREFIX=/usr For microb we have patch about this problem: http://hg.mozilla.org/users/romaxa_gmail.com/microb-patches/file/c45569001dbe/020_cs2007_rpath_wr.diff but for me it looks like workaround
Attached patch PREFIX->prefix (deleted) — Splinter Review
Seems PREFIX not defined anywhere, but $(prefix) is more better variable
Attachment #347142 - Flags: review?
Blocks: 422221
Attachment #347142 - Flags: review? → review?(ted.mielczarek)
Blocks: 401821
Assignee: nobody → romaxa
Attachment #347142 - Flags: review?(ted.mielczarek) → review+
Attachment #347142 - Flags: approval1.9.1?
Attachment #347142 - Flags: approval1.9.1? → approval1.9.1+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Backed out due to test failures: TEST-FAIL | build file copies are not in sync file(s) found in: /builds/slave/trunk_linux-7/build/js/src/config differ from their originals in: /builds/slave/trunk_linux-7/build/config file differs: ./system-headers In general, the files in '/builds/slave/trunk_linux-7/build/js/src/config' should always be exact copies of originals in '/builds/slave/trunk_linux-7/build/config'. A change made to one should also be made to the other. See 'check-sync-dirs.py' for more details. http://hg.mozilla.org/mozilla-central/rev/57c92d052aca
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I may have backed out the wrong patch to fix the orange. Sorry about that...
Attached patch Added same fix for JS configure. (obsolete) (deleted) — Splinter Review
Attachment #347142 - Attachment is obsolete: true
Attachment #352695 - Flags: review?
Your patch shouldn't have caused this bustage. configure.in is not checked between the top level and js/src, only the contents of the config/ directory. Just check your original patch back in.
Status: REOPENED → RESOLVED
Closed: 16 years ago16 years ago
Resolution: --- → FIXED
Should I land this patch to 1.9.1 ? or it is not so important for 1.9.1?
You have a patch on this bug that is flagged for 'review?' and not assigned to any reviewer. If you want the patch to be reviewed please assign a reviewer. Thanks
Attachment #352695 - Attachment is obsolete: true
Attachment #352695 - Flags: review?
Attachment #347142 - Attachment is obsolete: false
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: