Bug 459950 changed the in-page title of about:sessionrestore from "Your Last Firefox Session Closed Unexpectedly" (note the nice consistent capitalization) to "Would You Like to Restore Your Session?" (a question with almost-all capitals). This last label looks jarring with the combination of not all words captialized, large font size, and question mark. I propose making the label sentence case in English: "Would you like to restore your session?", as recommended by Windows [1] and GNOME [2] user interface guidelines. To give an idea of what the change looks like, see the attached screenshots. [1] http://i.msdn.microsoft.com/Aa511268.Dialogs23a(en-us,MSDN.10).png from http://msdn.microsoft.com/en-us/library/aa511268.aspx [2] http://library.gnome.org/devel/hig-book/stable/images/windows-alert-confirmation.png.en from http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en

I agree that it is quite ugly. Only the first word should be capitalized. I can create a patch for this if Alex agrees. Also, I CC'ed l10n because I'm not sure if the localizers also capitalized each word.

At first glance, de, fr, es-ES, es-AR, it, pl, ru, pt-PT, pt-BR, uk, lv, and el are not affected, and en-GB contains the same text as en.

Thanks Victor. So this would affect l10n here but luckily not that much. No patch has landed so removing late-l10n keyword. Not sure what I was thinking there.

The title is usually in title case, for instance: "Address Not Found"

True, though a question doesn't look particularly friendly in title case.

Ok, let's go with a normal sentence style (whenever we are able to update strings).

Patch changes "Would You Like to Restore Your Session?" to "Would you like to restore your session?"

Thanks Alex. I see that the patch in bug 459950 only got a ui-review+ and not a review+ so I'm assuming this patch doesn't need one also. So if my assumption is correct, this is ready to land on the trunk then I'll request approval for the branch.

Comment on attachment 350838 [details] [diff] [review] Patch We should just CC localizers based on http://mxr.mozilla.org/l10n-central/search?string=restorepage.pagetitle&find=owser/aboutSessionRestore.dtd on this bug and be done with it, no need to actually change the entity name here.

... sorry ... to be more instructive: This isn't really a semantic change of the string, and it isn't a widely spread polish issue in our localizations either, which would be the other reason to change the name, just to get a notification out. Thus, just fix the English string in-place, and we'll tell localizers that used capitalization to consider not doing that.

Comment on attachment 350838 [details] [diff] [review] Patch (In reply to comment #12) > ... sorry ... to be more instructive: > This isn't really a semantic change of the string, and it isn't a widely spread > polish issue in our localizations either, which would be the other reason to > change the name, just to get a notification out. > Thus, just fix the English string in-place, and we'll tell localizers that used > capitalization to consider not doing that. Roger that. New patch will be submitted tonight.

Addresses review comment. Does not change the string and only changes the capitalization of every word. Carrying over ui-review+ from faaborg.

Comment on attachment 351438 [details] [diff] [review] Patch 2.0 r=me, but my review is not sufficient for landing this patch, you'll need a browser peer, AFAIK.

Comment on attachment 351438 [details] [diff] [review] Patch 2.0 I think this patch has been sufficiently reviewed!

Comment on attachment 351438 [details] [diff] [review] Patch 2.0 Checkin needed on the trunk and branch. Not sure the requirement for baking on the trunk before branch checkin for low-risk patches.

http://hg.mozilla.org/mozilla-central/rev/a54efd040b25 (In reply to comment #17) > (From update of attachment 351438 [details] [diff] [review]) > Checkin needed on the trunk and branch. Not sure the requirement for baking on > the trunk before branch checkin for low-risk patches. It certainly needs approval.

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081212 Minefield/3.2a1pre ID:20081212040742 and on OS X. (In reply to comment #12) > Thus, just fix the English string in-place, and we'll tell localizers that used > capitalization to consider not doing that. Axel, just to make sure, have you notified the localizers about this change?

Comment on attachment 351438 [details] [diff] [review] Patch 2.0 a191=beltzner

Verified on 1.9.1 with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081223 Shiretoko/3.1b3pre ID:20081223022009 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081222 Shiretoko/3.1b3pre ID:20081222041930

This bug's priority relative to the set of other polish bugs is: P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.