Closed
Bug 464361
Opened 16 years ago
Closed 16 years ago
Add support for back and forward mouse buttons to View Source
Categories
(Toolkit :: View Source, enhancement)
Toolkit
View Source
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
steffen.wilberg
:
review+
beltzner
:
approval1.9.1b2+
|
Details | Diff | Splinter Review |
Add support for back and forward mouse buttons to View Source.
The code for the main browser window is here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.1037&mark=811-839,854#811
|
Assignee | |
Comment 1•16 years ago
|
||
Just copying some browser.js code to viewSource.js.
Attachment #347657 -
Flags: review?(gavin.sharp)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 347657 [details] [diff] [review]
patch
>diff --git a/toolkit/components/viewsource/content/viewSource.js b/toolkit/components/viewsource/content/viewSource.js
>+ default:
>+ break;
This is rather silly, just omit it?
Attachment #347657 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 347657 [details] [diff] [review]
patch
Seeking approval for this with the two lines mentioned in comment 2 dropped.
Attachment #347657 -
Flags: approval1.9.1b2?
|
|
Assignee | |
Updated•16 years ago
|
Attachment #347657 -
Attachment is obsolete: true
Attachment #347657 -
Flags: approval1.9.1b2?
|
|
Assignee | |
Comment 4•16 years ago
|
||
Nit fixed, indenting added, and bracing style adjusted.
Attachment #347864 -
Flags: review+
Attachment #347864 -
Flags: approval1.9.1b2?
|
||
Comment 5•16 years ago
|
||
Comment on attachment 347864 [details] [diff] [review]
for checkin
a=beltzner
Attachment #347864 -
Flags: approval1.9.1b2? → approval1.9.1b2+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 6•16 years ago
|
||
Does this handling include Alt+Left/Right arrow keys for back/forward navigation?
|
||
Comment 7•16 years ago
|
||
(In reply to comment #6)
> Does this handling include Alt+Left/Right arrow keys for back/forward
> navigation?
Alt+Left/Right should be working already, although I didn't specifically test that. Cmd+Left/Right do definitely work.
|
|
||
Comment 8•16 years ago
|
||
(In reply to comment #7)
> Alt+Left/Right should be working already, although I didn't specifically test
> that. Cmd+Left/Right do definitely work.
Yeah, they do! Sorry for the bugspam.
|
|
Assignee | |
Comment 9•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
You need to log in
before you can comment on or make changes to this bug.
Description
•