Ginn Chen Assignee
	Description • 16 years ago

The bug was reported at
http://defect.opensolaris.org/bz/show_bug.cgi?id=4845

The downloading file's mime-type is application/x-bz2.
GNOME doesn't have a default app for it.
Then we check the extension .bz2.
We get a default app (file-roller) and mime-type application/x-bzip, description is Bzip file.
We show it to user, user click ok.
When the file is downloaded, we tried to launch it by default app of application/x-bz2.
The default app doesn't exist.

	Ginn Chen Assignee
	Comment 1 • 16 years ago

We should use the mime-type from extension match, that is x-bzip in this case.

It is the same logic of win/nsOSHelperAppService.cpp

	Christian :Biesinger (don't email me, ping me on IRC)
	Comment 2 • 16 years ago

Why don't we launch it with the app we got earlier, i.e. file-roller?

	Ginn Chen Assignee
	Comment 3 • 16 years ago

Biesinger,

Sorry I missed your comment for a while.

(In reply to comment #2)
> Why don't we launch it with the app we got earlier, i.e. file-roller?

That's exactly I'm trying to fix.
We got file-roller earlier by extension .bz2.
If the user agrees to launch the file with system default helper application, 
the action is useSystemDefault.
When we try to launch it, we query the default app with mime-type again.
(see http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/unix/nsMIMEInfoUnix.cpp#101)
The mime-type is set to application/x-bz2 by the code I'm trying to remove.
So it fails to find default app.

	Micah Gersten
	Comment 4 • 15 years ago

Is this a dupe of bug 455626?

	Ginn Chen Assignee
	Comment 5 • 15 years ago

Yes, I think so.
But I don't quite understand the patch in bug 455626.
I think it doesn't make sense to look up again.
And why would we need to do GetHasDefaultHandler(), hasDefault is no longer used before "return".

I think the patch here is simpler.

	Ginn Chen Assignee
	Comment 7 • 14 years ago

Comment on attachment 347750 [details] [diff] [review]
patch

Fixed by Bug 327323.
However it is another approach.